Skip to content

storybook(ChatViewPage): Created ChatViewPage skeleton #17902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noeliaSD
Copy link
Contributor

@noeliaSD noeliaSD commented May 9, 2025

Closes #17879

What does the PR do

  • Just a first skeleton with some dummy channels and community data.
  • Interactions and navigations still not working

Affected areas

Storybook

Screenshot of functionality

Screenshot 2025-05-09 at 13 49 39

@noeliaSD noeliaSD requested review from micieslak, caybro, alexjba and a team as code owners May 9, 2025 11:51
@noeliaSD noeliaSD removed request for a team and alexjba May 9, 2025 11:51
@noeliaSD noeliaSD self-assigned this May 9, 2025
@status-im-auto
Copy link
Member

status-im-auto commented May 9, 2025

Jenkins Builds

Click to see older builds (13)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 27cb0eb #1 2025-05-09 12:00:57 ~9 min macos/aarch64 🍎dmg
✔️ 27cb0eb #1 2025-05-09 12:01:23 ~9 min tests/nim 📄log
27cb0eb #1 2025-05-09 12:03:05 ~11 min tests/ui 📄log
27cb0eb #1 2025-05-09 12:05:13 ~13 min windows/x86_64 📄log
✔️ 27cb0eb #1 2025-05-09 12:12:05 ~20 min macos/x86_64 🍎dmg
✔️ 27cb0eb #1 2025-05-09 12:13:43 ~22 min linux-nix/x86_64 📦tgz
✔️ 27cb0eb #1 2025-05-09 12:14:22 ~22 min linux/x86_64 📦tgz
27cb0eb #2 2025-05-09 14:18:32 ~11 min tests/ui 📄log
27cb0eb #2 2025-05-09 14:20:05 ~12 min windows/x86_64 📄log
27cb0eb #3 2025-05-12 07:34:08 ~13 min tests/ui 📄log
27cb0eb #3 2025-05-12 07:34:22 ~13 min windows/x86_64 📄log
✔️ 27cb0eb #4 2025-05-12 09:03:29 ~16 min windows/x86_64 💿exe
27cb0eb #4 2025-05-15 16:45:28 ~12 min tests/ui 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ af8fdf9 #2 2025-05-19 12:18:42 ~8 min macos/aarch64 🍎dmg
✔️ af8fdf9 #2 2025-05-19 12:19:27 ~9 min tests/nim 📄log
af8fdf9 #5 2025-05-19 12:22:43 ~12 min tests/ui 📄log
✔️ af8fdf9 #2 2025-05-19 12:28:15 ~17 min macos/x86_64 🍎dmg
✔️ af8fdf9 #5 2025-05-19 12:30:17 ~19 min windows/x86_64 💿exe
✔️ af8fdf9 #2 2025-05-19 12:34:24 ~24 min linux-nix/x86_64 📦tgz
✔️ af8fdf9 #2 2025-05-19 12:36:57 ~26 min linux/x86_64 📦tgz
✔️ e261437 #3 2025-05-20 09:17:15 ~9 min tests/nim 📄log
✔️ e261437 #3 2025-05-20 09:17:23 ~9 min macos/aarch64 🍎dmg
e261437 #6 2025-05-20 09:22:29 ~14 min tests/ui 📄log
✔️ e261437 #3 2025-05-20 09:23:32 ~15 min macos/x86_64 🍎dmg
✔️ e261437 #6 2025-05-20 09:26:50 ~18 min windows/x86_64 💿exe
✔️ e261437 #3 2025-05-20 09:27:00 ~18 min linux-nix/x86_64 📦tgz
✔️ e261437 #3 2025-05-20 09:28:26 ~20 min linux/x86_64 📦tgz

@noeliaSD noeliaSD force-pushed the storybook/chatViewPage branch from 27cb0eb to af8fdf9 Compare May 19, 2025 12:10
@@ -1,3 +1,4 @@
CreateChatPropertiesStore.qml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this little thing causes tests segfaults 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG 😱

Just a first skeleton with some dummy channels and community data.

Closes ##17879
@noeliaSD noeliaSD force-pushed the storybook/chatViewPage branch from af8fdf9 to e261437 Compare May 20, 2025 09:07
@noeliaSD noeliaSD marked this pull request as draft May 20, 2025 11:27
@noeliaSD noeliaSD requested review from alexjba and a team and removed request for alexjba and a team May 20, 2025 11:28
@noeliaSD
Copy link
Contributor Author

noeliaSD commented May 20, 2025

There are still issues not easy to solve here so I convert to draft to play a bit more with it.

  • Storybook validator is failling bc of how ChatContentView and ChatHeaderContentView is importing stores in the wrong way (relative paths) import "../stores"
  • Then there's another issue with MessageStore that is directly instantiated inside some UI components instead of injecting.

@noeliaSD
Copy link
Contributor Author

I'll come back again to this pr once some other tasks related to the following epic: #17874 are solved (at least remove MessageStore dependency or find an intermediate solution for this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QML Architecture][Chat] Create Base for ChatView Storybook Page
3 participants