refactor(accounts): remove keystore dir handling #18308
Open
+9
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed keyStoreDir property and its associated methods from the accounts service. - Updated `verifyAccountPassword` method, no longer require keyStoreDir. - Cleaned up login and account restoration processes by removing unnecessary keystore migration logic.
saledjenic
requested review from
alaibe,
friofry,
dlipicar,
igor-sirotin and
osmaczko
Jenkins Builds
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding
status-goPR:Corresponding
nim-status-goPR:initKeystoreremoved andverifyAccountPasswordupdated (keystoreDir param removed) nim-status-go#33Changes:
verifyAccountPasswordmethod, no longer require keyStoreDir.