refactor(api)_: removal / replacement of deprecated and obsolete funcs #4976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samyoul
requested review from
cammellos,
kounkou,
qfrank,
igor-sirotin,
osmaczko and
saledjenic
Jenkins BuildsClick to see older builds (37)
|
saledjenic
reviewed
Mar 25, 2024
api/backend.go
Outdated
|
|
||
| GetNodeConfig() (*params.NodeConfig, error) | ||
| UpdateRootDataDir(datadir string) | ||
|
|
||
| // SelectAccount(loginParams account.LoginParams) error | ||
| SelectAccount(loginParams account.LoginParams) error |
There was a problem hiding this comment.
Just wondering... if this function calls func (m *DefaultManager) SelectAccount(loginParams LoginParams) error and it expects loginParams.Password to be provided, won't that return an error in case of a keycard migrated profile?
There was a problem hiding this comment.
Interesting questions @saledjenic. I don't think that this change will break any existing flows.
This change only reintroduces the function signature to the StatusBackend interface. The implementation details of this function (whether loginParams.Password is expected etc) are a concern for the implementing struct.
However existing code, unaltered by this PR, that implements this function signature already uses the loginParams.Password property.
func (m *DefaultManager) SelectAccount(loginParams LoginParams) error {
m.mu.Lock()
defer m.mu.Unlock()
m.accountsGenerator.Reset()
selectedChatAccount, err := m.unlockExtendedKey(loginParams.ChatAddress.String(), loginParams.Password)
if err != nil {
return err
}
m.watchAddresses = loginParams.WatchAddresses
m.mainAccountAddress = loginParams.MainAccount
m.selectedChatAccount = selectedChatAccount
return nil
}This code is called via the LoginAccount API method. So perhaps a different API method is called when logging in via Keycard, because the failure would already be an issue without the changes in this PR.
There was a problem hiding this comment.
@Samyoul yes, I see what you've changed, no problem with your change at all, I just used the opportunity to ask does that somehow affect the keycard users, nothing else, sorry about confusion. :)
igor-sirotin
approved these changes
Mar 25, 2024
saledjenic
approved these changes
Mar 25, 2024
qfrank
approved these changes
Mar 27, 2024
kounkou
approved these changes
Mar 27, 2024
osmaczko
approved these changes
Jul 4, 2024
|
Oh no, Poor little PR . Thank you @osmaczko , I'll resolve the conflicts on merge |
igor-sirotin
force-pushed
the
chore/api-deprecation-refactor
branch
from
64ba08e to
9817bd4
Compare
|
Rebased this one. Hopefully no build issues. |
igor-sirotin
force-pushed
the
chore/api-deprecation-refactor
branch
from
9817bd4 to
cd730e8
Compare
igor-sirotin
changed the title
api - Refactor removal / replacement of deprecated and obsolete funcs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4976 +/- ##
============================================
+ Coverage 29.22% 59.20% +29.97%
============================================
Files 791 831 +40
Lines 98276 101480 +3204
============================================
+ Hits 28723 60080 +31357
+ Misses 65068 33816 -31252
- Partials 4485 7584 +3099
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…upgraded deprecated funcs
igor-sirotin
force-pushed
the
chore/api-deprecation-refactor
branch
from
c6520e6 to
6b70542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've resolved a number of refactor issues in the
apipackage.backend: Updated theStatusBackendinterface to match usagebackend_test: Resolved unhandled errors, import collisions and upgraded deprecated funcseth_backend: resolved import collisions