feat_: Update alias generated #6342
Open
+39
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulisesmac
commented
Feb 13, 2025
ulisesmac
commented
Feb 13, 2025
Jenkins BuildsClick to see older builds (74)
|
ulisesmac
force-pushed
the
fix-display-name
branch
from
91989c3 to
efe7105
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6342 +/- ##
===========================================
+ Coverage 61.09% 61.12% +0.02%
===========================================
Files 867 867
Lines 112673 112668 -5
===========================================
+ Hits 68843 68867 +24
+ Misses 35851 35846 -5
+ Partials 7979 7955 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilmotta
reviewed
Feb 17, 2025
ulisesmac
force-pushed
the
fix-display-name
branch
from
3635971 to
07005bb
Compare
ulisesmac
force-pushed
the
fix-display-name
branch
2 times, most recently
from
d912c7d to
4a938d1
Compare
|
@igor-sirotin @ilmotta The comments have been addressed, could you please review again? Thank you for the feedback! |
ilmotta
approved these changes
Feb 20, 2025
protocol/contact.go
Outdated
| return abbreviatedKey | ||
| } | ||
| return "" | ||
| func getShortenedCompressedKey(compressedKey string) string { |
There was a problem hiding this comment.
It seems that we can delete this function, which has only one usage and directly use alias.ShortenedCompressedKey(compressedKey)
ulisesmac
force-pushed
the
fix-display-name
branch
2 times, most recently
from
1283819 to
c1812f9
Compare
|
@igor-sirotin comments addressed, could you review again please? |
igor-sirotin
approved these changes
Feb 21, 2025
ulisesmac
force-pushed
the
fix-display-name
branch
2 times, most recently
from
bb9ff68 to
eac4403
Compare
|
@ulisesmac seems that |
|
@igor-sirotin Thank you, I'll check the tests and solve it. |
- Changed from the 3-words name to be the compressed key with an ellipsis - Update the shortened compressed key to be consistent with the alias - Add more tests about the public key length received
ulisesmac
force-pushed
the
fix-display-name
branch
from
eac4403 to
0f966a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required to acomplish
The context about this change is mainly in this Discord thread.
Summary
This PR changes the implementation of
GenerateFromPublicKeyStringto return a compressed key with ellipsis instead of the 3-words name.Important changes: