Skip to content

ci_: upgrade nixpkgs to 24.11 #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

ci_: upgrade nixpkgs to 24.11 #6577

merged 1 commit into from
Jun 24, 2025

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented May 14, 2025

Summary

  • point nixpkgs to commit from release-24.11
  • bump protobuf to 3_24
  • fix gomobile issue with : error: unable to find sdk: 'iphoneos'

@siddarthkay siddarthkay self-assigned this May 14, 2025
@status-im-auto
Copy link
Member

status-im-auto commented May 14, 2025

Jenkins Builds

Click to see older builds (128)
Commit #️⃣ Finished (UTC) Duration Platform Result
71b3402 #1 2025-05-14 15:35:27 ~3 min ios 📄log
✔️ 71b3402 #1 2025-05-14 15:37:47 ~6 min windows 📦zip
✔️ 71b3402 #1 2025-05-14 15:38:09 ~6 min macos 📦zip
✔️ 71b3402 #1 2025-05-14 15:38:22 ~6 min android 📦aar
✔️ 71b3402 #1 2025-05-14 15:41:20 ~9 min linux 📦zip
✔️ 71b3402 #1 2025-05-14 15:46:26 ~14 min tests-rpc 📄log
71b3402 #1 2025-05-14 15:46:43 ~15 min macos 📄log
✔️ 71b3402 #1 2025-05-14 16:12:47 ~41 min tests 📄log
✔️ a03e95a #2 2025-06-10 13:12:42 ~3 min android 📦aar
✔️ a03e95a #2 2025-06-10 13:12:44 ~3 min linux 📦zip
✔️ a03e95a #2 2025-06-10 13:13:43 ~4 min macos 📦zip
✔️ a03e95a #2 2025-06-10 13:15:21 ~5 min macos 📦zip
✔️ a03e95a #2 2025-06-10 13:15:30 ~5 min windows 📦zip
✔️ a03e95a #2 2025-06-10 13:17:20 ~7 min tests-rpc 📄log
✔️ a03e95a #2 2025-06-10 13:17:41 ~8 min ios 📦zip
✔️ a03e95a #1 2025-06-10 13:19:24 ~9 min linux 📦zip
✔️ a03e95a #2 2025-06-10 13:34:49 ~25 min tests 📄log
✔️ a84a318 #3 2025-06-10 13:21:13 ~2 min android 📦aar
✔️ a84a318 #3 2025-06-10 13:21:51 ~2 min linux 📦zip
✔️ a84a318 #3 2025-06-10 13:22:51 ~3 min macos 📦zip
✔️ a84a318 #3 2025-06-10 13:24:21 ~5 min macos 📦zip
✔️ a84a318 #3 2025-06-10 13:25:22 ~6 min windows 📦zip
✔️ a84a318 #3 2025-06-10 13:26:07 ~7 min tests-rpc 📄log
✔️ a84a318 #3 2025-06-10 13:26:15 ~7 min ios 📦zip
✔️ a84a318 #2 2025-06-10 13:26:51 ~7 min linux 📦zip
✔️ a84a318 #3 2025-06-10 13:59:23 ~24 min tests 📄log
b94f2dc #4 2025-06-13 10:51:20 ~3 min ios 📄log
✔️ b94f2dc #4 2025-06-13 10:53:06 ~5 min macos 📦zip
✔️ b94f2dc #4 2025-06-13 10:53:37 ~6 min android 📦aar
✔️ b94f2dc #4 2025-06-13 10:54:25 ~6 min linux 📦zip
✔️ b94f2dc #4 2025-06-13 10:54:38 ~7 min windows 📦zip
✔️ b94f2dc #4 2025-06-13 10:58:23 ~10 min macos 📦zip
✖️ b94f2dc #4 2025-06-13 10:58:59 ~11 min tests-rpc 📄log
✔️ b94f2dc #3 2025-06-13 11:01:44 ~14 min linux 📦zip
✔️ b94f2dc #4 2025-06-13 11:17:51 ~30 min tests 📄log
✔️ fd1496f #5 2025-06-13 10:56:41 ~3 min macos 📦zip
fd1496f #5 2025-06-13 10:57:24 ~5 min ios 📄log
5c3fab0 #6 2025-06-13 10:58:55 ~1 min ios 📄log
✔️ 5c3fab0 #5 2025-06-13 10:59:12 ~4 min linux 📦zip
✔️ 5c3fab0 #6 2025-06-13 11:00:12 ~3 min macos 📦zip
✔️ 5c3fab0 #5 2025-06-13 11:00:37 ~5 min windows 📦zip
✔️ 5c3fab0 #6 2025-06-13 11:01:20 ~4 min android 📦aar
✔️ 5c3fab0 #5 2025-06-13 11:01:54 ~3 min macos 📦zip
✔️ 5c3fab0 #6 2025-06-13 11:02:17 ~3 min linux 📦zip
✔️ 5c3fab0 #6 2025-06-13 11:06:18 ~5 min windows 📦zip
✔️ 5c3fab0 #5 2025-06-13 11:07:38 ~8 min tests-rpc 📄log
✔️ 5c3fab0 #4 2025-06-13 11:09:59 ~8 min linux 📦zip
✔️ 5c3fab0 #5 2025-06-13 11:43:06 ~25 min tests 📄log
✔️ 481c2ab #8 2025-06-14 07:53:17 ~2 min linux 📦zip
✔️ 481c2ab #7 2025-06-14 07:53:41 ~3 min macos 📦zip
✔️ 481c2ab #8 2025-06-14 07:53:54 ~3 min android 📦aar
✔️ 481c2ab #6 2025-06-14 07:55:24 ~5 min macos 📦zip
✔️ 481c2ab #7 2025-06-14 07:57:10 ~6 min windows 📦zip
✔️ 481c2ab #6 2025-06-14 07:57:58 ~7 min tests-rpc 📄log
✔️ 481c2ab #8 2025-06-14 07:58:06 ~7 min ios 📦zip
✔️ 481c2ab #5 2025-06-14 08:00:54 ~10 min linux 📦zip
✔️ 481c2ab #6 2025-06-14 08:16:28 ~26 min tests 📄log
✔️ c2f0caf #9 2025-06-14 07:56:13 ~2 min android 📦aar
✔️ c2f0caf #9 2025-06-14 07:56:36 ~3 min linux 📦zip
✔️ c2f0caf #8 2025-06-14 07:57:36 ~3 min macos 📦zip
✔️ c2f0caf #7 2025-06-14 08:00:31 ~5 min macos 📦zip
✔️ c2f0caf #8 2025-06-14 08:02:45 ~5 min windows 📦zip
✔️ c2f0caf #9 2025-06-14 08:04:33 ~6 min ios 📦zip
✔️ c2f0caf #7 2025-06-14 08:05:33 ~7 min tests-rpc 📄log
✔️ c2f0caf #6 2025-06-14 08:10:15 ~9 min linux 📦zip
✔️ c2f0caf #7 2025-06-14 08:41:25 ~24 min tests 📄log
✔️ 08a3d86 #10 2025-06-14 10:01:36 ~2 min linux 📦zip
✔️ 08a3d86 #10 2025-06-14 10:01:44 ~3 min android 📦aar
✔️ 08a3d86 #9 2025-06-14 10:01:53 ~3 min macos 📦zip
✔️ 08a3d86 #8 2025-06-14 10:03:40 ~4 min macos 📦zip
✔️ 08a3d86 #10 2025-06-14 10:04:35 ~5 min ios 📦zip
✔️ 08a3d86 #9 2025-06-14 10:04:37 ~5 min windows 📦zip
✔️ 08a3d86 #8 2025-06-14 10:06:03 ~7 min tests-rpc 📄log
✔️ 08a3d86 #7 2025-06-14 10:08:13 ~9 min linux 📦zip
✖️ 08a3d86 #8 2025-06-14 10:23:58 ~25 min tests 📄log
✔️ 08a3d86 #9 2025-06-14 10:52:30 ~25 min tests 📄log
✔️ 30daab7 #11 2025-06-22 05:42:36 ~3 min android 📦aar
✔️ 30daab7 #11 2025-06-22 05:42:55 ~3 min linux 📦zip
✔️ 30daab7 #10 2025-06-22 05:44:33 ~5 min macos 📦zip
✔️ 30daab7 #9 2025-06-22 05:44:51 ~5 min macos 📦zip
✔️ 30daab7 #10 2025-06-22 05:45:13 ~5 min windows 📦zip
✔️ 30daab7 #11 2025-06-22 05:46:49 ~7 min ios 📦zip
✖️ 30daab7 #9 2025-06-22 05:47:46 ~8 min tests-rpc 📄log
✔️ 30daab7 #8 2025-06-22 05:54:38 ~15 min linux 📦zip
✔️ 30daab7 #10 2025-06-22 06:05:04 ~25 min tests 📄log
✔️ 7293c08 #12 2025-06-22 05:45:37 ~2 min android 📦aar
✔️ 7293c08 #12 2025-06-22 05:46:23 ~3 min linux 📦zip
✔️ 7293c08 #11 2025-06-22 05:47:14 ~2 min macos 📦zip
✔️ 7293c08 #10 2025-06-22 05:49:53 ~4 min macos 📦zip
✔️ 7293c08 #11 2025-06-22 05:50:52 ~5 min windows 📦zip
✔️ 7293c08 #12 2025-06-22 05:52:23 ~5 min ios 📦zip
✖️ 7293c08 #10 2025-06-22 05:55:08 ~7 min tests-rpc 📄log
✔️ 7293c08 #9 2025-06-22 06:06:00 ~11 min linux 📦zip
✖️ 7293c08 #11 2025-06-22 06:31:02 ~25 min tests 📄log
✔️ bce5455 #13 2025-06-22 06:35:04 ~2 min android 📦aar
✔️ bce5455 #12 2025-06-22 06:35:11 ~2 min macos 📦zip
✔️ bce5455 #13 2025-06-22 06:35:59 ~3 min linux 📦zip
✔️ bce5455 #11 2025-06-22 06:37:48 ~5 min macos 📦zip
✔️ bce5455 #13 2025-06-22 06:37:51 ~5 min ios 📦zip
✖️ bce5455 #11 2025-06-22 06:39:37 ~7 min tests-rpc 📄log
✔️ bce5455 #10 2025-06-22 06:41:03 ~8 min linux 📦zip
✔️ 9a80ebc #14 2025-06-22 06:37:39 ~2 min android 📦aar
✔️ 9a80ebc #13 2025-06-22 06:37:57 ~2 min macos 📦zip
✔️ 9a80ebc #13 2025-06-22 06:38:50 ~5 min windows 📦zip
✔️ 9a80ebc #14 2025-06-22 06:39:29 ~3 min linux 📦zip
✔️ 9a80ebc #12 2025-06-22 06:42:53 ~4 min macos 📦zip
✔️ 9a80ebc #14 2025-06-22 06:43:20 ~5 min ios 📦zip
✖️ 9a80ebc #12 2025-06-22 06:46:39 ~6 min tests-rpc 📄log
✔️ 9a80ebc #11 2025-06-22 06:50:18 ~9 min linux 📦zip
✔️ 9a80ebc #13 2025-06-22 06:58:30 ~25 min tests 📄log
✔️ 3316ef5 #15 2025-06-22 06:49:30 ~2 min android 📦aar
✔️ 3316ef5 #14 2025-06-22 06:49:51 ~2 min macos 📦zip
✔️ 3316ef5 #15 2025-06-22 06:50:00 ~2 min linux 📦zip
✔️ 3316ef5 #13 2025-06-22 06:52:21 ~5 min macos 📦zip
✔️ 3316ef5 #15 2025-06-22 06:52:40 ~5 min ios 📦zip
✔️ 3316ef5 #14 2025-06-22 06:52:48 ~5 min windows 📦zip
✖️ 3316ef5 #13 2025-06-22 06:53:45 ~6 min tests-rpc 📄log
✔️ 3316ef5 #12 2025-06-22 06:59:01 ~8 min linux 📦zip
✖️ 3316ef5 #14 2025-06-22 07:24:31 ~25 min tests 📄log
✔️ 1c39a59 #15 2025-06-23 11:22:19 ~2 min macos 📦zip
✔️ 1c39a59 #16 2025-06-23 11:23:10 ~3 min android 📦aar
✔️ 1c39a59 #16 2025-06-23 11:23:26 ~3 min linux 📦zip
✔️ 1c39a59 #14 2025-06-23 11:24:41 ~4 min macos 📦zip
✔️ 1c39a59 #15 2025-06-23 11:27:54 ~8 min windows 📦zip
✔️ 1c39a59 #14 2025-06-23 11:28:24 ~8 min tests-rpc 📄log
✔️ 1c39a59 #16 2025-06-23 11:28:27 ~8 min ios 📦zip
✔️ 1c39a59 #13 2025-06-23 11:29:57 ~10 min linux 📦zip
✔️ 1c39a59 #15 2025-06-23 11:47:51 ~28 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 01e23bf #16 2025-06-24 15:44:07 ~2 min macos 📦zip
✖️ 01e23bf #16 2025-06-24 15:45:37 ~4 min tests 📄log
✔️ 01e23bf #15 2025-06-24 15:46:43 ~5 min macos 📦zip
✔️ 01e23bf #17 2025-06-24 15:47:10 ~5 min ios 📦zip
✔️ 01e23bf #17 2025-06-24 15:47:24 ~6 min android 📦aar
✔️ 01e23bf #17 2025-06-24 15:47:44 ~6 min linux 📦zip
✔️ 01e23bf #16 2025-06-24 15:47:45 ~6 min windows 📦zip
✖️ 01e23bf #15 2025-06-24 15:48:46 ~7 min tests-rpc 📄log
✔️ 01e23bf #14 2025-06-24 15:53:43 ~12 min linux 📦zip
✔️ 3069513 #17 2025-06-24 15:46:57 ~2 min macos 📦zip
✔️ 3069513 #18 2025-06-24 15:50:35 ~3 min android 📦aar
✔️ 3069513 #18 2025-06-24 15:51:18 ~3 min linux 📦zip
✔️ 3069513 #16 2025-06-24 15:51:42 ~4 min macos 📦zip
✔️ 3069513 #18 2025-06-24 15:52:48 ~5 min ios 📦zip
✔️ 3069513 #17 2025-06-24 15:53:31 ~5 min windows 📦zip
✔️ 3069513 #16 2025-06-24 15:54:16 ~5 min tests-rpc 📄log
✔️ 3069513 #15 2025-06-24 16:05:34 ~11 min linux 📦zip
✔️ 3069513 #17 2025-06-24 16:10:53 ~25 min tests 📄log

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.37%. Comparing base (7258e73) to head (3069513).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6577      +/-   ##
===========================================
+ Coverage    60.15%   60.37%   +0.22%     
===========================================
  Files          830      830              
  Lines       103533   103532       -1     
===========================================
+ Hits         62279    62508     +229     
+ Misses       33685    33511     -174     
+ Partials      7569     7513      -56     
Flag Coverage Δ
functional 28.18% <ø> (+0.16%) ⬆️
unit 58.48% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

@igor-sirotin
Copy link
Collaborator

igor-sirotin commented May 15, 2025

kek, so we'll need to fix it all at once? 😅

@siddarthkay siddarthkay force-pushed the bump-nixpkgs-24-11 branch 2 times, most recently from a03e95a to a84a318 Compare June 10, 2025 13:18
@siddarthkay siddarthkay changed the title ci: upgrade nixpkgs to 24.11 ci_: upgrade nixpkgs to 24.11 Jun 10, 2025
@siddarthkay siddarthkay marked this pull request as ready for review June 10, 2025 13:19
@siddarthkay siddarthkay requested a review from a team as a code owner June 10, 2025 13:19
@siddarthkay siddarthkay marked this pull request as draft June 10, 2025 13:27
@siddarthkay siddarthkay force-pushed the bump-nixpkgs-24-11 branch 7 times, most recently from c2f0caf to 08a3d86 Compare June 14, 2025 09:58
@siddarthkay siddarthkay marked this pull request as ready for review June 14, 2025 09:58
@siddarthkay siddarthkay mentioned this pull request Jun 14, 2025
1 task
@siddarthkay siddarthkay force-pushed the bump-nixpkgs-24-11 branch 5 times, most recently from 9a80ebc to 3316ef5 Compare June 22, 2025 06:46
@siddarthkay siddarthkay requested a review from jakubgs June 22, 2025 06:47
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess infra team can say more here 🙂

@siddarthkay siddarthkay force-pushed the bump-nixpkgs-24-11 branch 2 times, most recently from 01e23bf to e2b1b53 Compare June 24, 2025 15:42
- point `nixpkgs` to commit from `release-24.11`
- bump `protobuf` to `3_24`
- fix `gomobile` issue with : `error: unable to find sdk: 'iphoneos'`
@siddarthkay siddarthkay merged commit 3069513 into develop Jun 24, 2025
24 checks passed
@siddarthkay siddarthkay deleted the bump-nixpkgs-24-11 branch June 24, 2025 16:12
@@ -64,11 +73,17 @@ buildGo122Module {
ln -s $src $out/src/golang.org/x/mobile
'';

# to fix : error: unable to find sdk: 'iphoneos'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is bad, we don't know what it refers to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I missed this, I was trying to be concise.
The full error was

 > /nix/store/5c4b1rmbak441s22150gb99crs0jppgb-gomobile-0-unstable-2024-12-13/bin/
gomobile: xcrun --find: exit status 255
> error: unable to find sdk: 'iphoneos'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants