-
Notifications
You must be signed in to change notification settings - Fork 255
ci_: upgrade nixpkgs to 24.11 #6577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (128)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6577 +/- ##
===========================================
+ Coverage 60.15% 60.37% +0.22%
===========================================
Files 830 830
Lines 103533 103532 -1
===========================================
+ Hits 62279 62508 +229
+ Misses 33685 33511 -174
+ Partials 7569 7513 -56
Flags with carried forward coverage won't be shown. Click here to find out more. |
kek, so we'll need to fix it all at once? 😅 |
a03e95a
to
a84a318
Compare
c2f0caf
to
08a3d86
Compare
9a80ebc
to
3316ef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess infra team can say more here 🙂
3316ef5
to
1c39a59
Compare
01e23bf
to
e2b1b53
Compare
- point `nixpkgs` to commit from `release-24.11` - bump `protobuf` to `3_24` - fix `gomobile` issue with : `error: unable to find sdk: 'iphoneos'`
e2b1b53
to
3069513
Compare
@@ -64,11 +73,17 @@ buildGo122Module { | |||
ln -s $src $out/src/golang.org/x/mobile | |||
''; | |||
|
|||
# to fix : error: unable to find sdk: 'iphoneos' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is bad, we don't know what it refers to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I missed this, I was trying to be concise.
The full error was
> /nix/store/5c4b1rmbak441s22150gb99crs0jppgb-gomobile-0-unstable-2024-12-13/bin/
gomobile: xcrun --find: exit status 255
> error: unable to find sdk: 'iphoneos'
Summary
nixpkgs
to commit fromrelease-24.11
protobuf
to3_24
gomobile
issue with :error: unable to find sdk: 'iphoneos'