feat_: integrate sds protocol. #6639
Draft
+855
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (118)
|
gabrielmer
force-pushed
the
feat/sds-integration
branch
from
96e6359 to
5488a21
Compare
jm-clius
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Thanks! Looked through this and it seems reasonable to me - at least the functionality of wrapping and unwrapping a message. Would be great to see more of the callbacks stubbed (perhaps in a next PR?). The idea of the basic integration is simply to add logs that demonstrate what kind of reliability information we get from SDS, as you are indeed doing. Are there any other mechanisms (e.g. metrics) available to make monitoring even easier?
The grafana & promethues can probably help, but looks not straight forward since we likely want to track the graph somehow. |
kaichaosun
force-pushed
the
feat/sds-integration
branch
from
46117ba to
e70f4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDS is a protocol to improve reliability of community messages. SDS spec
A description to understand introduced changes without reading the code.
Important changes:
ApplicationMetadataMessagefor SDSRelates #waku-org/pm#194