Skip to content

ci_: get rid of dirty flag #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

siddarthkay
Copy link
Contributor

Summary

I found few instances of --dirty in status-go as well,
Now that we don't have this versioning in status-desktop it would be consistent if we removed it from here as well.

@siddarthkay siddarthkay self-assigned this Jun 14, 2025
@siddarthkay siddarthkay requested a review from a team as a code owner June 14, 2025 07:56
@status-im-auto
Copy link
Member

status-im-auto commented Jun 14, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8256c15 #1 2025-06-14 07:58:51 ~2 min android 📦aar
✔️ 8256c15 #1 2025-06-14 07:59:30 ~2 min linux 📦zip
✔️ 8256c15 #1 2025-06-14 07:59:57 ~3 min macos 📦zip
✔️ 8256c15 #1 2025-06-14 08:01:34 ~4 min windows 📦zip
✔️ 8256c15 #1 2025-06-14 08:02:26 ~5 min macos 📦zip
✔️ 8256c15 #1 2025-06-14 08:04:25 ~7 min ios 📦zip
✔️ 8256c15 #1 2025-06-14 08:04:42 ~7 min tests-rpc 📄log
✔️ 8256c15 #1 2025-06-14 08:07:25 ~10 min linux 📦zip
✔️ 8256c15 #1 2025-06-14 08:21:58 ~25 min tests 📄log

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.56%. Comparing base (16b886f) to head (8256c15).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6677      +/-   ##
===========================================
+ Coverage    60.47%   60.56%   +0.09%     
===========================================
  Files          828      828              
  Lines       103720   103720              
===========================================
+ Hits         62727    62821      +94     
+ Misses       33389    33318      -71     
+ Partials      7604     7581      -23     
Flag Coverage Δ
functional 27.78% <ø> (+0.13%) ⬆️
unit 58.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/version/version.go 100.00% <ø> (ø)

... and 27 files with indirect coverage changes

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. But what's wrong with it? It was there for a reason 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants