Skip to content

chore!: remove waku service #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

osmaczko
Copy link
Contributor

@osmaczko osmaczko commented Jun 25, 2025

Closes #6663

Tested in: status-im/status-desktop#18306

Copy link

github-actions bot commented Jun 25, 2025

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

@osmaczko osmaczko requested review from dlipicar and plopezlpz June 25, 2025 13:56
@osmaczko osmaczko changed the title Chore/remove waku service chore!: remove waku service Jun 25, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jun 25, 2025

Jenkins Builds

Click to see older builds (109)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e9e0df4 #1 2025-06-25 13:58:35 ~2 min macos 📦zip
✔️ e9e0df4 #1 2025-06-25 13:58:41 ~2 min android 📦aar
✔️ e9e0df4 #1 2025-06-25 13:59:16 ~3 min linux 📦zip
✖️ e9e0df4 #1 2025-06-25 13:59:25 ~3 min tests 📄log
✔️ e9e0df4 #1 2025-06-25 14:00:33 ~4 min ios 📦zip
✔️ e9e0df4 #1 2025-06-25 14:00:40 ~4 min macos 📦zip
✔️ e9e0df4 #1 2025-06-25 14:00:56 ~4 min windows 📦zip
✔️ e9e0df4 #1 2025-06-25 14:05:19 ~9 min linux 📦zip
✖️ e9e0df4 #1 2025-06-25 14:13:31 ~17 min tests-rpc 📄log
✔️ 5f63937 #2 2025-06-25 14:22:24 ~3 min android 📦aar
✔️ 5f63937 #2 2025-06-25 14:22:42 ~3 min macos 📦zip
✔️ 5f63937 #2 2025-06-25 14:23:00 ~3 min linux 📦zip
✔️ 5f63937 #2 2025-06-25 14:23:37 ~4 min macos 📦zip
✖️ 5f63937 #2 2025-06-25 14:24:06 ~4 min tests 📄log
✔️ 5f63937 #2 2025-06-25 14:24:21 ~5 min ios 📦zip
✔️ 5f63937 #2 2025-06-25 14:25:32 ~6 min windows 📦zip
✔️ 5f63937 #2 2025-06-25 14:27:26 ~8 min linux 📦zip
✖️ 5f63937 #2 2025-06-25 14:36:43 ~17 min tests-rpc 📄log
✔️ 66656db #3 2025-06-25 17:44:36 ~2 min macos 📦zip
✔️ 66656db #3 2025-06-25 17:45:51 ~3 min linux 📦zip
✔️ 66656db #3 2025-06-25 17:45:57 ~3 min macos 📦zip
✔️ 66656db #3 2025-06-25 17:47:37 ~5 min ios 📦zip
✔️ 66656db #3 2025-06-25 17:48:16 ~6 min windows 📦zip
✔️ 66656db #3 2025-06-25 17:53:32 ~11 min linux 📦zip
✖️ 66656db #3 2025-06-25 17:59:13 ~17 min tests-rpc 📄log
✖️ 66656db #3 2025-06-25 18:06:33 ~24 min tests 📄log
✔️ b0e4f40 #4 2025-06-27 17:17:39 ~2 min android 📦aar
✔️ b0e4f40 #4 2025-06-27 17:17:53 ~2 min macos 📦zip
✔️ b0e4f40 #4 2025-06-27 17:18:39 ~3 min linux 📦zip
✔️ b0e4f40 #4 2025-06-27 17:18:54 ~3 min macos 📦zip
✔️ b0e4f40 #4 2025-06-27 17:19:12 ~4 min ios 📦zip
✔️ b0e4f40 #5 2025-06-27 17:20:33 ~2 min android 📦aar
✔️ b0e4f40 #4 2025-06-27 17:20:47 ~5 min windows 📦zip
✔️ b0e4f40 #5 2025-06-27 17:21:06 ~2 min macos 📦zip
✔️ b0e4f40 #5 2025-06-27 17:22:55 ~4 min linux 📦zip
✔️ b0e4f40 #5 2025-06-27 17:22:56 ~3 min macos 📦zip
✔️ b0e4f40 #5 2025-06-27 17:23:34 ~4 min ios 📦zip
✔️ b0e4f40 #4 2025-06-27 17:25:59 ~11 min linux 📦zip
✔️ b0e4f40 #5 2025-06-27 17:26:34 ~5 min windows 📦zip
✖️ b0e4f40 #4 2025-06-27 17:32:37 ~17 min tests-rpc 📄log
✔️ b0e4f40 #5 2025-06-27 17:38:58 ~12 min linux 📦zip
✖️ b0e4f40 #4 2025-06-27 17:40:27 ~25 min tests 📄log
✖️ b0e4f40 #5 2025-06-27 17:50:48 ~18 min tests-rpc 📄log
✔️ 4f3a62d #6 2025-06-27 17:36:47 ~2 min macos 📦zip
✔️ 4f3a62d #6 2025-06-27 17:37:30 ~3 min android 📦aar
✔️ 4f3a62d #6 2025-06-27 17:38:01 ~3 min linux 📦zip
✔️ 4f3a62d #6 2025-06-27 17:38:07 ~3 min macos 📦zip
✔️ 4f3a62d #6 2025-06-27 17:38:25 ~4 min ios 📦zip
✔️ 4f3a62d #6 2025-06-27 17:41:05 ~6 min windows 📦zip
✔️ 4f3a62d #6 2025-06-27 17:49:59 ~10 min linux 📦zip
✖️ 4f3a62d #5 2025-06-27 18:05:24 ~24 min tests 📄log
✖️ 4f3a62d #6 2025-06-27 18:07:19 ~16 min tests-rpc 📄log
✔️ a639464 #7 2025-07-01 14:45:33 ~3 min android 📦aar
✔️ a639464 #7 2025-07-01 14:46:04 ~3 min macos 📦zip
✔️ a639464 #7 2025-07-01 14:46:09 ~4 min macos 📦zip
✔️ a639464 #7 2025-07-01 14:46:29 ~4 min linux 📦zip
✔️ a639464 #7 2025-07-01 14:47:55 ~5 min windows 📦zip
✖️ a639464 #7 2025-07-01 14:48:28 ~6 min tests-rpc 📄log
✔️ a639464 #7 2025-07-01 14:50:16 ~8 min ios 📦zip
✔️ a639464 #7 2025-07-01 14:57:26 ~15 min linux 📦zip
✖️ a639464 #6 2025-07-01 15:10:45 ~28 min tests 📄log
✔️ a639464 #8 2025-07-01 16:04:24 ~2 min macos 📦zip
✔️ a639464 #8 2025-07-01 16:04:44 ~3 min android 📦aar
✔️ a639464 #8 2025-07-01 16:05:24 ~3 min macos 📦zip
✔️ a639464 #8 2025-07-01 16:06:03 ~4 min linux 📦zip
✔️ a639464 #8 2025-07-01 16:07:01 ~5 min ios 📦zip
✖️ a639464 #8 2025-07-01 16:07:08 ~5 min tests-rpc 📄log
✔️ a639464 #8 2025-07-01 16:07:33 ~5 min windows 📦zip
✔️ a639464 #8 2025-07-01 16:12:58 ~11 min linux 📦zip
✖️ a639464 #7 2025-07-01 16:29:20 ~27 min tests 📄log
✔️ 7a14398 #9 2025-07-01 16:08:34 ~3 min android 📦aar
✔️ 7a14398 #9 2025-07-01 16:08:57 ~4 min macos 📦zip
✔️ 7a14398 #9 2025-07-01 16:09:21 ~3 min macos 📦zip
✔️ 7a14398 #9 2025-07-01 16:12:51 ~6 min linux 📦zip
✔️ 7a14398 #9 2025-07-01 16:12:53 ~5 min ios 📦zip
✔️ 7a14398 #9 2025-07-01 16:14:26 ~6 min windows 📦zip
✖️ 7a14398 #9 2025-07-01 16:19:09 ~11 min tests-rpc 📄log
✔️ 7a14398 #9 2025-07-01 16:25:56 ~12 min linux 📦zip
✖️ 7a14398 #8 2025-07-01 16:56:25 ~26 min tests 📄log
✖️ 7a14398 #10 2025-07-02 12:08:33 ~5 min tests-rpc 📄log
✖️ 7a14398 #9 2025-07-02 12:30:08 ~27 min tests 📄log
✔️ 27f8745 #10 2025-07-03 15:49:24 ~2 min android 📦aar
✔️ 27f8745 #10 2025-07-03 15:50:01 ~2 min macos 📦zip
✔️ 27f8745 #10 2025-07-03 15:50:10 ~2 min linux 📦zip
✔️ 27f8745 #10 2025-07-03 15:51:03 ~3 min macos 📦zip
✔️ 27f8745 #10 2025-07-03 15:51:26 ~4 min ios 📦zip
✖️ 27f8745 #11 2025-07-03 15:53:02 ~5 min tests-rpc 📄log
✔️ 27f8745 #10 2025-07-03 15:55:18 ~7 min windows 📦zip
✔️ 27f8745 #10 2025-07-03 15:57:36 ~10 min linux 📦zip
✖️ 27f8745 #10 2025-07-03 16:15:41 ~28 min tests 📄log
✔️ 8c0ae9d #11 2025-07-03 15:57:16 ~2 min android 📦aar
✔️ 8c0ae9d #11 2025-07-03 15:57:49 ~2 min macos 📦zip
✔️ 8c0ae9d #11 2025-07-03 15:58:06 ~3 min linux 📦zip
✔️ 8c0ae9d #11 2025-07-03 15:59:06 ~3 min macos 📦zip
✔️ 8c0ae9d #11 2025-07-03 15:59:13 ~4 min ios 📦zip
✖️ 8c0ae9d #12 2025-07-03 16:00:45 ~5 min tests-rpc 📄log
✔️ 8c0ae9d #11 2025-07-03 16:01:00 ~5 min windows 📦zip
✔️ 8c0ae9d #11 2025-07-03 16:05:11 ~7 min linux 📦zip
✔️ 8c0ae9d #11 2025-07-03 16:40:30 ~24 min tests 📄log
✖️ 9280efe #12 2025-07-03 21:15:10 ~2 min tests 📄log
✔️ 9280efe #12 2025-07-03 21:15:20 ~2 min macos 📦zip
✔️ 9280efe #12 2025-07-03 21:15:27 ~3 min android 📦aar
✔️ 9280efe #12 2025-07-03 21:15:51 ~3 min linux 📦zip
✔️ 9280efe #12 2025-07-03 21:16:25 ~3 min macos 📦zip
✔️ 9280efe #12 2025-07-03 21:16:49 ~4 min ios 📦zip
✔️ 9280efe #13 2025-07-03 21:17:54 ~5 min tests-rpc 📄log
✔️ 9280efe #12 2025-07-03 21:18:45 ~6 min windows 📦zip
✔️ 9280efe #12 2025-07-03 21:22:12 ~9 min linux 📦zip
✔️ 9280efe #13 2025-07-04 08:50:23 ~24 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6656a73 #13 2025-07-04 09:07:18 ~2 min android 📦aar
✔️ 6656a73 #13 2025-07-04 09:07:50 ~2 min macos 📦zip
✔️ 6656a73 #13 2025-07-04 09:07:57 ~2 min linux 📦zip
✔️ 6656a73 #13 2025-07-04 09:09:01 ~3 min macos 📦zip
✔️ 6656a73 #13 2025-07-04 09:09:13 ~4 min ios 📦zip
✖️ 6656a73 #14 2025-07-04 09:11:04 ~5 min tests-rpc 📄log
✔️ 6656a73 #13 2025-07-04 09:11:13 ~6 min windows 📦zip
✔️ 6656a73 #13 2025-07-04 09:15:18 ~10 min linux 📦zip
✔️ 6656a73 #15 2025-07-04 09:18:22 ~5 min tests-rpc 📄log
✔️ 6656a73 #14 2025-07-04 09:30:12 ~25 min tests 📄log
✔️ 318a0ef #14 2025-07-09 21:37:14 ~2 min android 📦aar
✔️ 318a0ef #14 2025-07-09 21:38:16 ~3 min linux 📦zip
✔️ 318a0ef #14 2025-07-09 21:39:04 ~4 min macos 📦zip
✔️ 318a0ef #14 2025-07-09 21:39:31 ~4 min ios 📦zip
✔️ 318a0ef #14 2025-07-09 21:39:59 ~4 min windows 📦zip
✔️ 318a0ef #14 2025-07-09 21:40:14 ~5 min macos 📦zip
✖️ 318a0ef #16 2025-07-09 21:41:01 ~5 min tests-rpc 📄log
✔️ 318a0ef #14 2025-07-09 21:45:02 ~9 min linux 📦zip
✔️ 318a0ef #15 2025-07-09 22:00:28 ~25 min tests 📄log

@osmaczko osmaczko force-pushed the chore/remove-waku-service branch 3 times, most recently from 66656db to b0e4f40 Compare June 27, 2025 17:14
@osmaczko osmaczko changed the base branch from develop to chore/remove-local-pairing-integration-tests June 27, 2025 17:15
@osmaczko osmaczko force-pushed the chore/remove-waku-service branch from b0e4f40 to 4f3a62d Compare June 27, 2025 17:33
@osmaczko osmaczko force-pushed the chore/remove-local-pairing-integration-tests branch from ce71b82 to fc39def Compare July 1, 2025 14:47
Base automatically changed from chore/remove-local-pairing-integration-tests to develop July 1, 2025 16:01
@osmaczko osmaczko force-pushed the chore/remove-waku-service branch from a639464 to 7a14398 Compare July 1, 2025 16:03
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 64.58333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 59.66%. Comparing base (e16dc91) to head (318a0ef).

Files with missing lines Patch % Lines
services/ext/service.go 63.01% 18 Missing and 9 partials ⚠️
api/geth_backend.go 41.66% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6711      +/-   ##
===========================================
+ Coverage    59.60%   59.66%   +0.05%     
===========================================
  Files          818      818              
  Lines       100651   100643       -8     
===========================================
+ Hits         59997    60049      +52     
+ Misses       33092    32992     -100     
- Partials      7562     7602      +40     
Flag Coverage Δ
functional 28.40% <61.45%> (-0.06%) ⬇️
unit 56.90% <63.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
node/get_status_node.go 71.17% <ø> (+1.00%) ⬆️
node/geth_node.go 58.53% <ø> (ø)
node/status_node_services.go 79.03% <100.00%> (+0.92%) ⬆️
protocol/messenger.go 63.23% <100.00%> (-0.08%) ⬇️
protocol/messenger_mailserver.go 45.10% <100.00%> (-0.54%) ⬇️
services/wakuv2ext/api.go 100.00% <ø> (ø)
services/wakuv2ext/service.go 100.00% <100.00%> (+14.28%) ⬆️
wakuv2/gowaku.go 67.28% <100.00%> (-0.99%) ⬇️
api/geth_backend.go 55.35% <41.66%> (+0.09%) ⬆️
services/ext/service.go 28.76% <63.01%> (+4.55%) ⬆️

... and 55 files with indirect coverage changes

@osmaczko osmaczko force-pushed the chore/remove-waku-service branch 3 times, most recently from 9280efe to 6656a73 Compare July 4, 2025 09:04
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@@ -2690,7 +2683,12 @@ func (b *GethStatusBackend) LocalPairingStarted() error {
return accountDB.MnemonicWasShown()
}

func (b *GethStatusBackend) injectAccountsIntoWakuService(w wakutypes.WakuKeyManager, st *ext.Service) error {
func (b *GethStatusBackend) initProtocol() error {
st := b.statusNode.WakuV2ExtService()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you "remove waku service"? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is different 😅 Famous WakuExt, soon renamed to protocol.

@osmaczko osmaczko force-pushed the chore/remove-waku-service branch from 6656a73 to 318a0ef Compare July 9, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove waku service
4 participants