-
Notifications
You must be signed in to change notification settings - Fork 255
chore!: remove waku service #6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Jenkins BuildsClick to see older builds (109)
|
66656db
to
b0e4f40
Compare
b0e4f40
to
4f3a62d
Compare
ce71b82
to
fc39def
Compare
a639464
to
7a14398
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6711 +/- ##
===========================================
+ Coverage 59.60% 59.66% +0.05%
===========================================
Files 818 818
Lines 100651 100643 -8
===========================================
+ Hits 59997 60049 +52
+ Misses 33092 32992 -100
- Partials 7562 7602 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9280efe
to
6656a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏👏
@@ -2690,7 +2683,12 @@ func (b *GethStatusBackend) LocalPairingStarted() error { | |||
return accountDB.MnemonicWasShown() | |||
} | |||
|
|||
func (b *GethStatusBackend) injectAccountsIntoWakuService(w wakutypes.WakuKeyManager, st *ext.Service) error { | |||
func (b *GethStatusBackend) initProtocol() error { | |||
st := b.statusNode.WakuV2ExtService() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you "remove waku service"? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is different 😅 Famous WakuExt
, soon renamed to protocol
.
closes: #6663
6656a73
to
318a0ef
Compare
chore!: remove statusd (This needs to wait for Extract the push-notification service from statusd into a separate command #6503 )
chore!: remove waku service
Closes #6663
Tested in: status-im/status-desktop#18306