test_: reliability fixes #6736
Merged
test_: reliability fixes #6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (27)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6736 +/- ##
========================================
Coverage 59.28% 59.28%
========================================
Files 828 828
Lines 101465 101465
========================================
Hits 60152 60152
+ Misses 33764 33744 -20
- Partials 7549 7569 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
approved these changes
Jul 4, 2025
| @@ -7,7 +7,9 @@ class NetworkConditionsSteps: | |||
| @contextmanager | |||
| def add_latency(self, node, latency=300, jitter=50): | |||
| logging.info("Entering context manager: add_latency") | |||
| node.container_exec(f"apk add iproute2 && tc qdisc add dev eth0 root netem delay {latency}ms {jitter}ms distribution normal") | |||
| node.container_exec( | |||
| f"apt-get update && apt-get install -y iproute2 && tc qdisc add dev eth0 root netem delay {latency}ms {jitter}ms distribution normal" | |||
There was a problem hiding this comment.
hmm, why dot we have this as part of Dockerfile?
There was a problem hiding this comment.
I did tried it in this commit
but when I try to use it, it will not find the package, now sure why.
Let me do another try, maybe I've missed something
There was a problem hiding this comment.
no luck, it seems that the package is not installed
|
Thanks for the fix btw. And sorry for breaking it 😄 |
rlve
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the reliability tests green again https://github.com/status-im/status-go/actions/runs/16075568798