Skip to content

Migration: SDoc model: Merge Section, Node, Composite Node into just Node #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
29 of 32 tasks
stanislaw opened this issue Apr 27, 2025 · 3 comments
Open
29 of 32 tasks
Milestone

Comments

@stanislaw
Copy link
Collaborator

stanislaw commented Apr 27, 2025

Task

Why?

  • Closer compatibility to ReqIF which does not have Sections but only recursive nodes.
  • First-class support of Composite Requirements in all generators and the UI.
  • Remove a lot of duplication between Section and Node because section is just a hardcoded node in many aspects.
@KlfJoat
Copy link

KlfJoat commented Jun 2, 2025

#2257:

The [COMPOSITE_REQUIREMENT] node has been removed from the codebase. This is a backward-incompatible change, but it is assumed that no users should be affected since this feature has never been developed enough to be useful.

cough #1623 Am I "no user" to you? 😁

I'm kidding. It seems that custom nodes will be a full-featured replacement for [COMPOSITE_REQUIREMENT], so I'm good. But I thought I'd drop in and maybe give you a chuckle. ☺️

I'm glad to see so much progress in StrictDoc! Thanks a lot for all you do!

@stanislaw
Copy link
Collaborator Author

Hi @KlfJoat, thanks for the heads-up. I had to make such an assumption to make progress in a reasonable time. The new Pip with this migration has not been released yet, but indeed, just following the migration guide and renaming to [[COMPOSITE_REQUIREMENT]] or other name and creating a corresponding grammar element should pretty much work.

There is now a considerable effort I am putting into making both [SECTION] and [[SECTION]] to work at the same time, and the goal is to make both old and new behaviors work without anything breaking.

You could give it some testing on the nightly release. Let me know if it does the job.

@KlfJoat
Copy link

KlfJoat commented Jun 3, 2025

I had to make such an assumption to make progress in a reasonable time.

Absolutely fine. You did mention that I was one of the few people using the feature, back in that old Issue. I was just trying to make a joke. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants