feat: 🎸 support extends prop in tsconfig #302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisermann
commented
Jan 29, 2021
Comment on lines
+70
to
+82
| if (typeof config.extends === 'string') { | ||
| const parentConfigPath = join( | ||
| process.cwd(), | ||
| dirname(tsconfigFile), | ||
| config.extends, | ||
| ); | ||
|
|
||
| Object.assign( | ||
| compilerOptionsJSON, | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires, node/global-require, @typescript-eslint/no-require-imports | ||
| require(parentConfigPath).compilerOptions, | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is the important bit
kaisermann
commented
Jan 29, 2021
Comment on lines
+109
to
+128
| const importTransformer: ts.TransformerFactory<ts.SourceFile> = (context) => { | ||
| const visit: ts.Visitor = (node) => { | ||
| if (ts.isImportDeclaration(node)) { | ||
| if (node.importClause?.isTypeOnly) { | ||
| return ts.createEmptyStatement(); | ||
| } | ||
|
|
||
| return ts.createImportDeclaration( | ||
| node.decorators, | ||
| node.modifiers, | ||
| node.importClause, | ||
| node.moduleSpecifier, | ||
| ); | ||
| } | ||
|
|
||
| return ts.visitEachChild(node, (child) => visit(child), context); | ||
| }; | ||
|
|
||
| return (node) => ts.visitNode(node, visit); | ||
| }; |
kaisermann
commented
Jan 29, 2021
| // Support extending another tsconfig | ||
| if (typeof config.extends === 'string') { | ||
| const parentConfigPath = join( | ||
| process.cwd(), |
There was a problem hiding this comment.
I'm not sure about using cwd as base here, but we need an absolute path here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300