[lldb] Run async tests using back-deployment target #3490
Conversation
|
@swift-ci test |
| def test_backdeploy(self): | ||
| """Test function arguments in async functions""" | ||
| self.build(dictionary={ | ||
| 'TARGET_SWIFTFLAGS': f'-target {self.getArchitecture()}-apple-macos11' |
There was a problem hiding this comment.
This is the first time I'm seeing these nifty format string literals. Are they supported by all python versions that LLDB can build under?
There was a problem hiding this comment.
I'll get rid of these. I forgot that f-strings are Python 3.6+, not all versions of Python 3.
| @skipIf(oslist=['windows', 'linux']) | ||
| def test_backdeploy(self): | ||
| """Test function arguments in async functions""" | ||
| self.build(dictionary={ |
There was a problem hiding this comment.
Maybe add a comment here that the first macOS to natively support async was macos12?
| @swiftTest | ||
| @skipIfWindows | ||
| @skipIfLinux | ||
| @skipIf(archs=no_match(["arm64", "arm64e", "arm64_32", "x86_64"])) |
There was a problem hiding this comment.
Why is this necessary? It sounds like this basically excludes i386-apple-macos11, which I think isn't a thing?
On the other hand we may need to @skipDarwinEmbedded since the triple explictly asks for macos.
There was a problem hiding this comment.
I'll review and fix these. You're no doubt right. I duplicated the existing function and kept its decorations without looking closely at them.
| def test_actor_backdeploy(self): | ||
| """Test async unwind""" | ||
| self.build(dictionary={ | ||
| 'TARGET_SWIFTFLAGS': f'-target {self.getArchitecture()}-apple-macos11' |
There was a problem hiding this comment.
I'm curious if this is better than using SWIFTFLAGS_EXTRAS. Are the makefiles themselves defining SWIFTFLAGS_EXTRAS?
There was a problem hiding this comment.
Yes the Makefiles are defining SWIFTFLAGS_EXTRAS. I believe it didn't work when I tried. I can double check.
For each of the async tests, extract the test body into a function (in some cases this already existed), and then duplicate each
test*function to a*_backdeploytest. The back-deploy tests build formacos11, which is a back deployment target.