Skip to content

Revert "Revert "Merge pull request #9493 from jimingham/swift-call-si… #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: stable/20240723
Choose a base branch
from

Conversation

jimingham
Copy link

…te-breakpoints""

This reverts commit c93fb6d.

…t-call-site-breakpoints""

This reverts commit c93fb6d.
@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

Naturally, reapplying the revert shows no failure in the REPL test that was failing yesterday...

@jimingham
Copy link
Author

This was reverted due to an intermittent (and not very plausibly related to this patch) stall in the test BreakpointSimple.test. I can only repro that test failure on the bots. I'm pushing a change that adds some logging to that test that we should see if it fails.

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

Still not failing.

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

Still not failing, let's try again.

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

We got another failure, this time tough, I had turned on the packet log for the test. I made the test fail artificially, and when it did, I see the packet log output in the Filecheck error reporting, but there are no packet logs here. So it seems that this test never got to launching the victim program. I'm going to try again, first with an artificial failure to make sure the bots aren't suppressing the packet output when reporting errors, then with breakpoint and process logging on to see if we get anywhere.

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

I've had no luck reproducing this locally on an Ubuntu VM.

@jimingham
Copy link
Author

Okay, when we get an actual failure we see all these logs. That must mean that the "RUN" part of this .test file is actually hanging somewhere. Let's see if it is setting the breakpoint, or calling the function to hit it.

@jimingham
Copy link
Author

@swift-ci please test Linux macOS

@jimingham
Copy link
Author

@swift-ci please test Linux macOS

@jimingham
Copy link
Author

@swift-ci please test Linux

@jimingham
Copy link
Author

Try a few more times to see if it will fail just setting the breakpoint.

@jimingham
Copy link
Author

@swift-ci please test Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant