-
Notifications
You must be signed in to change notification settings - Fork 344
Revert "Revert "Merge pull request #9493 from jimingham/swift-call-si… #9550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable/20240723
Are you sure you want to change the base?
Revert "Revert "Merge pull request #9493 from jimingham/swift-call-si… #9550
Conversation
…t-call-site-breakpoints"" This reverts commit c93fb6d.
@swift-ci please test Linux |
Naturally, reapplying the revert shows no failure in the REPL test that was failing yesterday... |
This was reverted due to an intermittent (and not very plausibly related to this patch) stall in the test BreakpointSimple.test. I can only repro that test failure on the bots. I'm pushing a change that adds some logging to that test that we should see if it fails. |
@swift-ci please test Linux |
Still not failing. |
@swift-ci please test Linux |
Still not failing, let's try again. |
@swift-ci please test Linux |
@swift-ci please test Linux |
We got another failure, this time tough, I had turned on the packet log for the test. I made the test fail artificially, and when it did, I see the packet log output in the Filecheck error reporting, but there are no packet logs here. So it seems that this test never got to launching the victim program. I'm going to try again, first with an artificial failure to make sure the bots aren't suppressing the packet output when reporting errors, then with breakpoint and process logging on to see if we get anywhere. |
@swift-ci please test Linux |
I've had no luck reproducing this locally on an Ubuntu VM. |
Okay, when we get an actual failure we see all these logs. That must mean that the "RUN" part of this .test file is actually hanging somewhere. Let's see if it is setting the breakpoint, or calling the function to hit it. |
@swift-ci please test Linux macOS |
@swift-ci please test Linux macOS |
@swift-ci please test Linux |
Try a few more times to see if it will fail just setting the breakpoint. |
@swift-ci please test Linux |
…te-breakpoints""
This reverts commit c93fb6d.