Transition Path to FilePath #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlysingh
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
I think we'll need to look at the test failures on a case by case basis to make sure we're not unintentionally breaking compatibility with existing projects, but overall the implementation changes here lgtm. I'll kickoff CI so we can get an idea of where we might need to take a closer look for possible behavior changes |
|
@swift-ci please test |
|
based on the test output here it looks like there might be a lingering issue with path normalization: |
|
@swift-ci please test |
swiftlysingh
force-pushed
the
task/removes-useLegacyImplementation-#23
branch
from
af8548a to
22871e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Path struct within
Sources/SWBUtil/Path.swiftto exclusively use the FilePath type for internal path representation and manipulation.The legacy implementation toggle has been removed as part of this change. Note that some tests are currently failing due to behavioural differences after the FilePath migration. Should the FilePath implementation be adjusted to align with the expected test behaviours?
Feedback is appreciated. Relates to issue #23.