Reapply #1160, Add fix to allow more padding characters than necessary #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
May 13, 2025
fabianfett
force-pushed
the
ff-base64-new-try
branch
from
53c3a46 to
54f610c
Compare
|
@swift-ci test |
itingliu
reviewed
May 14, 2025
| @@ -33,13 +43,10 @@ extension Data { | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
Previously in #1160, you removed these #if FOUNDATION_FRAMEWORK path so we call into a unified implementation. Is it intentional that you aren't doing that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.