Proposal to generate UUIDs using RandomNumberGenerators
#1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-random-uuid
branch
2 times, most recently
from
fb5c82f to
df12e88
Compare
itingliu
reviewed
Apr 25, 2025
FranzBusch
force-pushed
the
fb-random-uuid
branch
from
df12e88 to
8f18f07
Compare
This PR adds a proposal to generate `UUID's` using `RandomNumberGenerator`s
FranzBusch
force-pushed
the
fb-random-uuid
branch
from
8f18f07 to
d9ffe2f
Compare
| var secondBits = second | ||
|
|
||
| // Set the version to 4 (0100 in binary) | ||
| firstBits &= 0xFFFFFFFFFFFF0FFF // Clear the last 12 bits |
There was a problem hiding this comment.
Is the code wrong or the comment wrong? This appears to clear bits 12 ... 15.
There was a problem hiding this comment.
The comment was wrong. This clears bits 48-51 of the UInt64 aligned with the RFC. Example below
10010100 10010010 10111010 11000100 11110011 01010011 00101001 11100111
10010100 10010010 10111010 11000100 11110011 01010011 00001001 11100111
FranzBusch
force-pushed
the
fb-random-uuid
branch
from
0ef6492 to
96cc29c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proposal to generate
UUID'susingRandomNumberGenerators