Skip to content

Update install-ubuntu.md #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2025
Merged

Update install-ubuntu.md #1275

merged 3 commits into from
Feb 27, 2025

Conversation

thomas-zimmerman
Copy link
Contributor

Add a "apt upgrade" after the PPA is added.

@thomas-zimmerman
Update install-ubuntu.md
6ab683a 
Add a "apt upgrade" after the PPA is added.
@leviport leviport requested review from a team February 26, 2025 19:11
leviport
leviport requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we removed sudo apt update after adding the PPA in #1274, shouldn't we do the same here to make it consistent? Either that or remove it in #1274 because sudo apt update won't hurt anything. Either way, I just feel like they should match.

@ahoneybun
Update install-ubuntu.md
0448147 
remove apt update after adding the PPA as it runs by default now.
@ahoneybun ahoneybun requested a review from leviport February 27, 2025 14:55
@leviport leviport requested review from a team and removed request for leviport February 27, 2025 16:02
@ahoneybun ahoneybun merged commit 4359a69 into master Feb 27, 2025
3 checks passed
@ahoneybun ahoneybun deleted the thomas-zimmerman-patch-1 branch February 27, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoneybun ahoneybun ahoneybun approved these changes

@leviport leviport leviport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas-zimmerman @ahoneybun @leviport