confgen(FieldProp): support sequence in auto-merge map keys, keyed list keys, and normal fields #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Kybxd
commented
Apr 24, 2025
•
Kybxd
commented
- close FieldProp(sequence ): support sequence check even when parent same-key auto merge #163
- close FieldProp(sequence): extend sequence ability for normal integer field #162
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 71.00% 71.13% +0.13%
==========================================
Files 80 80
Lines 10184 10189 +5
==========================================
+ Hits 7231 7248 +17
+ Misses 2388 2376 -12
Partials 565 565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kybxd
force-pushed
the
confgen.sequence-auto-merge
branch
from
a2966d4 to
a4b0c43
Compare
Kybxd
changed the title
wenchy
changed the title
wenchy
requested changes
May 6, 2025
internal/confgen/parser.go
Outdated
Comment on lines
560
to
562
| func (sp *sheetParser) checkListKeyUnique(field *Field, reflectList protoreflect.List, keyData string) error { | ||
| // TODO: we need to cache key field descriptor for reuse, to avoid each loop to find it when parse table rows or document nodes. | ||
| md := reflectList.NewElement().Message().Descriptor() |
There was a problem hiding this comment.
For higher performance, we'd better NOT create new element for getting MessageDescriptor, it is costy. Just use the provided parameter md ?
internal/confgen/parser.go
Outdated
| } | ||
| seq := keyField.opts.Prop.GetSequence() | ||
| len := int64(reflectMap.Len()) | ||
| val, err := strconv.ParseInt(keyData, 10, 64) |
There was a problem hiding this comment.
- Too many same code lines in the two func:
checkMapKeySequenceandcheckListKeySequence, please encaplulate the same code lines to one func. strconv.ParseInt(keyData, 10, 64)only supportint64, but will not supportuint64when its value is out-bound-ofint64.
There was a problem hiding this comment.
- done
- no need to support since values > max int64 is hardly used.
tableau.protoalso declares sequence as int64
Kybxd
force-pushed
the
confgen.sequence-auto-merge
branch
from
0ac88bc to
1e899a2
Compare
Kybxd
force-pushed
the
confgen.sequence-auto-merge
branch
from
1e899a2 to
5670fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.