Skip to content

Conversation

Kybxd
Copy link
Collaborator

@Kybxd Kybxd commented Apr 24, 2025

❗BREAKING CHANGE

If field prop sequence is set in map field in a table sheet (Excel/CSV), it will now be generated to scalar field key's field prop of map value, but not the map field itself.

Compatibility resolution

If field prop sequence is set in map field in a table sheet (Excel/CSV), please regenerate its proto files for upgrading.
For example:
image

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 78.50467% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (4b09f7c) to head (94add5f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/confgen/parser.go 82.25% 8 Missing and 3 partials ⚠️
internal/confgen/table_parser.go 73.33% 5 Missing and 3 partials ⚠️
internal/confgen/document_parser.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   71.28%   71.39%   +0.10%     
==========================================
  Files          83       83              
  Lines       10342    10350       +8     
==========================================
+ Hits         7372     7389      +17     
+ Misses       2404     2394      -10     
- Partials      566      567       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kybxd Kybxd force-pushed the confgen.sequence-auto-merge branch from a2966d4 to a4b0c43 Compare April 25, 2025 03:20
@Kybxd Kybxd changed the title feat: support sequence in auto-merge map keys feat: support sequence in auto-merge map keys, keyed list keys, and normal fields Apr 28, 2025
@wenchy wenchy changed the title feat: support sequence in auto-merge map keys, keyed list keys, and normal fields confgen(FieldProp): support sequence in auto-merge map keys, keyed list keys, and normal fields May 6, 2025
@Kybxd Kybxd force-pushed the confgen.sequence-auto-merge branch 2 times, most recently from 1e899a2 to 5670fdd Compare May 14, 2025 09:22
@Kybxd Kybxd force-pushed the confgen.sequence-auto-merge branch from 5670fdd to f6022cb Compare May 30, 2025 11:44
@Kybxd Kybxd changed the title confgen(FieldProp): support sequence in auto-merge map keys, keyed list keys, and normal fields FieldProp(BREAKING!): support sequence in auto-merge map keys, keyed list keys, and normal fields Jul 9, 2025
@wenchy wenchy force-pushed the confgen.sequence-auto-merge branch from f6022cb to 82f5a96 Compare July 12, 2025 12:40
@wenchy wenchy merged commit fcfe01e into master Jul 12, 2025
9 checks passed
@wenchy wenchy deleted the confgen.sequence-auto-merge branch July 12, 2025 13:09
@wenchy wenchy mentioned this pull request Jul 5, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants