-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Don't consider the global important state in @apply
#18404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, just a few suggestions.
I tested this on Catalyst and Tailwind Plus to make sure the output is identical (especially because we don't use @apply
there). And the output is the same 👍
Co-authored-by: Robin Malfait <[email protected]>
RobinMalfait
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18400
In v3 when you used
important: true
it did not affect@apply
. However, in v4 it does and there's no way to make it not. This is definitely a bug and would be unexpected for users coming from v3 who use@apply
andimportant
together.Basically, the following code, along with the detected utility
flex
in source files…… would output this:
But it's expected that
@apply
doesn't consider the "global" important state. This PR addresss this problem and now the output is this:If you want to mark a utility as important in
@apply
you can still use!
after the utility to do so as shown above.