Support decimal parameters in sql structures #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running a test the other day using the existing
SqlServerGuidItemItemSetMapFactscode and noticed that the test would break after callingMapFacts<Guid, Item>.CreateValue(Guid)in a loop. The issue is that a property of typedecimalon the createdItemwould start to have values too big for its corresponding decimal SQL column.As I tried to customize the precision and scale of the decimal column, I noticed Elephant currently supports only customizing the length of
nvarcharandvarbinarytypes.Thus, I'm adding support for customizing the precision and scale of decimal types and I'm also increasing the default precision to 15 (from 9)