Skip to content

Add coverage support #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dagwieers
Copy link
Contributor

This adds coverage support for unit tests.

@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@744281a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   92.52%           
=========================================
  Files             ?        2           
  Lines             ?      174           
  Branches          ?        0           
=========================================
  Hits              ?      161           
  Misses            ?       13           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744281a...9e723d5. Read the comment docs.

@dagwieers

This comment has been minimized.

@dagwieers
Copy link
Contributor Author

The latest changes disable the @codecov-io bot.

@dagwieers dagwieers force-pushed the coverage branch 17 times, most recently from b52eb33 to 7659d67 Compare September 4, 2019 23:55
@dagwieers
Copy link
Contributor Author

dagwieers commented Sep 5, 2019

So a coverage of 97.94% is the best we can do without Mocking xbmc and xbmcaddon.
If we want to get to 100% coverage we have to be able to import xbmc and xbmcaddon.
I don't mind doing that if you agree.

https://codecov.io/gh/tamland/kodi-plugin-routing/commits

@dagwieers dagwieers force-pushed the coverage branch 4 times, most recently from 6965442 to 000c23f Compare September 5, 2019 00:04
This PR includes:
- Coverage support for unit tests
- Disables the codecov bot
- Add more tests to get close to 100% coverage
- Improve coverage and bugfixes to tests
- Rename log() to _log()
- Remove an impossible KeyError exception
- Use Kodistubs for testing
@dagwieers
Copy link
Contributor Author

Can we see this merged? It would be nice to know exactly what has not been covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants