dml: store source in struct #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalt
force-pushed
the
askalt/store-source-in-dml
branch
from
3788ebc to
3321c4e
Compare
This patch adds a field `dst` into struct `DmlStatement`. No reason to do it in the other way than for a table scan, where we store the table source. Whereas storing a dst adds the ability to analyze the table for which DML operation is performed. It is useful for analyzer/optimizer passes writing.
askalt
force-pushed
the
askalt/store-source-in-dml
branch
from
3321c4e to
3605664
Compare
psergee
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a field
dstinto structDmlStatement. No reason todo it in the other way than for a table scan, where we store the table
source. Whereas storing a dst adds the ability to analyze the table
for which DML operation is performed. It is useful for analyzer/optimizer
passes writing.