Skip to content

Fix replicas metrics for tarantool raft #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

reo7sp
Copy link
Contributor

@reo7sp reo7sp commented Jul 23, 2024

Change replica detection from using function box.cfg.read_only to box.info.ro.

Function box.info.ro can be true in case of autofailover-leader change, but box.cfg.read_only may not.

Reference:

  1. Lua-function box.info.ro calls C-function box_is_ro: info.c#L349.
  2. C-function box_is_ro uses variable is_ro_summary: box.cc#L551.
  3. Variable is_ro_summary is a sum of value box.cfg.read_only, orphan status and autofailover-leader status: box.cc#L360.
  4. Variable is_ro_summary is recomputed on autofailover-leader change: raft.c#L205

@yngvar-antonsson yngvar-antonsson merged commit bafc0d5 into tarantool:master Aug 14, 2024
yngvar-antonsson added a commit that referenced this pull request Aug 16, 2024
yngvar-antonsson added a commit that referenced this pull request Aug 16, 2024
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 11, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

NO_DOC=doc is a part of the submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 11, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

NO_DOC=doc is a part of the submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 11, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

NO_DOC=doc is a part of the submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 13, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

NO_DOC=doc is a part of the submodule
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 13, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

@TarantoolBot document
Title: Document `metrics.cfg{include={'cpu_extended'}}`

`'cpu_extended'` is a new category of default metrics, introduced in
metrics 1.3.0. It can be enabled or disabled separately, same as
other categories.
DifferentialOrange added a commit to DifferentialOrange/tarantool that referenced this pull request Mar 13, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

@TarantoolBot document
Title: Document `metrics.cfg{include={'cpu_extended'}}`

`'cpu_extended'` is a new category of default metrics, introduced in
metrics 1.3.0. It can be enabled or disabled separately, same as
other categories.
Totktonada pushed a commit to tarantool/tarantool that referenced this pull request Mar 14, 2025
Bump metrics package submodule. Commits from PRs [1-2] affect
Tarantool, the other ones are related to module infrastructure.

1. tarantool/metrics#495
2. tarantool/metrics#498

@TarantoolBot document
Title: Document `metrics.cfg{include={'cpu_extended'}}`

`'cpu_extended'` is a new category of default metrics, introduced in
metrics 1.3.0. It can be enabled or disabled separately, same as
other categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants