abstract: fix switch in_replicaset value #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`running` state should switch to `ending` if rw->ro case.
This test failed due to the use of undeclared variables. The patch makes these variables local.
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-185-fix-ddl-usage
branch
from
7440c00 to
48a4dc6
Compare
LeonidVas
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Hi! Thank you for the patchset.
Good catch.
About commit messages:
- "abstract: error if failed to create a temp tube" -> "abstract: throw an error if failed to create a temp tube"
- "The create_table method returns" -> "The create_tube method returns"
- "fix: switch in_replicaset value with tnt < 2.2.1" - "fix" not is a subsystem.
The create_tube method returns a tube or throws an error in almost all cases. It is unexpected that only in one case it returns nil and writes an error message into a log. The patch unifies the behavior of this method.
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-185-fix-ddl-usage
branch
from
48a4dc6 to
5c1e839
Compare
Thank you, I've tried to do the best: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message |
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-185-fix-ddl-usage
branch
from
5c1e839 to
c86c21e
Compare
Execution of non-yielding DDL statements in transactions has been allowed only since Tarantool 2.2.1 [1]. We should avoid using DDL statements in transactions for older versions. 1. tarantool/tarantool@f266559 Closes #185
oleg-jukovec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution of non-yielding DDL statements in transactions has been allowed only since Tarantool 2.2.1 [1]. We should avoid using DDL statements in transactions for older versions.
Closes #185
This patchset includes a few fixes, mostly typos. So I recommend to review commits one by one. I can extract it into a separate pull request, if you wish, but the fixes are really small.