Skip to content

implemented lifottl queue type #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maxim-komar
Copy link

implemented lifottl queue type

@LeonidVas
Copy link
Contributor

Hi. Thank you for the patch. Sorry for the big latency.
It's look like copy-paste of the fifottl driver with an overload of the take method (and this is expected). But WET is bad practice. I propose to pick out common code and write fifottl and lifottl as a wrapper around this (something like limfifottl relatively to fifottl).

@LeonidVas LeonidVas self-requested a review October 19, 2020 11:28
@LeonidVas LeonidVas closed this Oct 21, 2020
@LeonidVas
Copy link
Contributor

LeonidVas commented Oct 21, 2020

Useful part of the PR is five lines of code, everything else - "copy-paste" from the fifottl driver. I agree that "copy-paste" methodology was used in the module for creating new drivers from existing ones. But support such code is difficult. I think DRY principle is a good practice and suggest to move common code to a separate file/module.
Back to the PR, I created an issue to implement the lifo and lifottl drivers.
As for the unreasonably long feedback delays in the PR review: the party's policy has been changed and now part of the team's resource is allocated for this activity and it is expected such delays will gone. So, if you want, you can try to implement the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants