gives the developer feedback if something is wrong with the icons directory (parse-community#363)

* icons

* moved directory to index.js

* final

parse-dashboard now check for the icons directory and also each app icon

* removed log call and fixed code indention

* catch error if folder doesn't exist at start

and show error why the dashboard couldn’t be started

Author: Saif Al-Dilaimi

Parse-Dashboard/app.js

@@ -3,6 +3,7 @@ const express = require('express');
 const basicAuth = require('basic-auth');
 const path = require('path');
 const packageJson = require('package-json');
+var fs = require('fs');
 
 const currentVersionFeatures = require('../package.json').parseDashboardFeatures;
 
@@ -26,6 +27,26 @@ function getMount(req) {
   return mountPath;
 }
 
+function checkIfIconsExistForApps(apps, iconsFolder) {
+  for (var i in apps) {
+    var currentApp = apps[i];
+    var iconName = currentApp.iconName;
+    var path = iconsFolder + "/" + iconName;
+
+    fs.stat(path, function(err, stat) {
+      if (err != null && err.code == 'ENOENT') {
+        // file does not exist
+        console.warn("Icon with file name: " + iconName +
+          " couldn't be found in icons folder!");
+      } else {
+        console.log(
+          'An error occurd while checking for icons, please check permission: ',
+          err.code);
+      }
+    });
+  }
+}
+
 module.exports = function(config, allowInsecureHTTP) {
   var app = express();
   // Serve public files.
@@ -116,7 +137,18 @@ module.exports = function(config, allowInsecureHTTP) {
   // We are explicitly not using `__dirpath` here because one may be
   // running parse-dashboard from globally installed npm.
   if (config.iconsFolder) {
-    app.use('/appicons', express.static(config.iconsFolder));
+    try {
+      var stat = fs.statSync(config.iconsFolder);
+      if (stat.isDirectory()) {
+        app.use('/appicons', express.static(config.iconsFolder));
+        //Check also if the icons really exist
+        checkIfIconsExistForApps(config.apps, config.iconsFolder);
+      }
+    } catch (e) {
+      // Directory doesn't exist or something.
+      console.warn("Iconsfolder at path: " + config.iconsFolder +
+        " not found!");
+    } 
   }
 
   // For every other request, go to index.html. Let client-side handle the rest.

Parse-Dashboard/index.js

@@ -117,7 +117,7 @@ p.then(config => {
     var fs = require('fs');
     var privateKey = fs.readFileSync(configSSLKey);
     var certificate = fs.readFileSync(configSSLCert);
-   
+
     const server = require('https').createServer({
       key: privateKey,
       cert: certificate
@@ -143,6 +143,6 @@ p.then(config => {
   }
 })
 .catch(error => {
-  console.log('There was a problem loading the dashboard. Exiting.');
+  console.log('There was a problem loading the dashboard. Exiting.', error);
   process.exit(-1);
 });

Parse-Dashboard/parse-dashboard-config.json

@@ -1,5 +1,10 @@
 {
-  "apps": [
-
-  ]
+  "apps": [{
+    "serverURL": "",
+    "appId": "",
+    "masterKey": "",
+    "appName": "",
+    "iconName": ""
+  }],
+  "iconsFolder": "icons"
 }