gives the developer feedback if something is wrong with the icons directory #363
Conversation
|
By analyzing the blame information on this pull request, we identified @drew-gross, @flovilmart and @Vortec4800 to be potential reviewers. |
ghost
added
| @@ -26,10 +28,32 @@ function getMount(req) { | |||
| return mountPath; | |||
| } | |||
|
|
|||
| function checkIfIconsExistForApps(apps, iconsFolder) { | |||
| for (var i in apps) { | |||
| console.log(JSON.stringify(apps[i])); | |||
There was a problem hiding this comment.
Please remove extra console.log
There was a problem hiding this comment.
Shame on me. Will remove it as soon as I'm home.
|
Awesome! The code looks good except for that one extra |
|
Oh I see. Yeah this is atoms pretty code style 😞 Gotta check if I can disable that. Else I will just paste those lines by hand. |
|
@deada92 updated the pull request. |
|
I think this is better now.. |
and show error why the dashboard couldn’t be started
|
@deada92 updated the pull request. |
|
Sweet! Looks good to me! |
|
Great to see that the icons feature is being continued. Thanks, @deada92 ! |
|
Sure anytime. If there's something else I can help with tag me. I'm just not that good with react else I would make it possible to upload the icon directly. |
#359