Skip to content

Bun conversion #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bun conversion #163

wants to merge 5 commits into from

Conversation

jlsnow301
Copy link

This will call bun instead of node, see the PR tgstation/tgstation#91359

@tgstation-operations-ci tgstation-operations-ci bot added the CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. label Jun 6, 2025
@tgstation-operations-ci
Copy link
Contributor

As this pull request is from a fork, the Colmena workflow requires repository secrets to deploy to staging. Maintainers can add the CI Cleared label to allow it to run. Note that any changes to ci_security.yml, colmena.yml, and colmena_deploy.yml will not be reflected.

@optimumtact optimumtact added the CI Cleared Applying this label allows a pull request from a fork to access repository secrets label Jun 6, 2025
@tgstation-operations-ci tgstation-operations-ci bot removed the CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. label Jun 6, 2025
@ZephyrTFA ZephyrTFA enabled auto-merge June 6, 2025 13:45
@tgstation-operations-ci tgstation-operations-ci bot added CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. and removed CI Cleared Applying this label allows a pull request from a fork to access repository secrets labels Jun 6, 2025
@optimumtact optimumtact added the CI Cleared Applying this label allows a pull request from a fork to access repository secrets label Jun 8, 2025
@tgstation-operations-ci tgstation-operations-ci bot removed the CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. label Jun 8, 2025
auto-merge was automatically disabled June 9, 2025 00:56

Head branch was pushed to by a user without write access

@tgstation-operations-ci tgstation-operations-ci bot added CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. and removed CI Cleared Applying this label allows a pull request from a fork to access repository secrets labels Jun 9, 2025
jlsnow301
jlsnow301 commented Jun 9, 2025
View reviewed changes
systems/game-servers/modules/tgs/EventScripts/tg/PreCompile.sh Outdated
Comment on lines 77 to 78
# Get unzip
apt-get install -y unzip
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need this bc bun install requires it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apt in nix, this needs to be installed via the configs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it as an option to this list of system packages i believe

https://github.com/tgstation-operations/infrastructure/blob/main/systems/game-servers/modules/tgs/default.nix#L10

Copy link
Author

@jlsnow301 jlsnow301 Jun 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also packages for tgs in that same file, specifically node, L131. this seems more precise?

i'm still confused if this line is needed for it to run on tgstation ci

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the right spot. The one oranges linked isn't

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to remove the apt get line. i just wonder if this means it won't work on tgstation CI.

Cyberboss
Cyberboss requested changes Jun 9, 2025
View reviewed changes
systems/game-servers/modules/tgs/EventScripts/tg/PreCompile.sh Outdated
Comment on lines 77 to 78
# Get unzip
apt-get install -y unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apt in nix, this needs to be installed via the configs.

@tgstation-operations-ci tgstation-operations-ci bot added CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. and removed CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. labels Jun 9, 2025
@optimumtact optimumtact added the CI Cleared Applying this label allows a pull request from a fork to access repository secrets label Jun 9, 2025
@tgstation-operations-ci tgstation-operations-ci bot removed the CI Approval Required Approval is required to allow workflows to access secrets. Review the PR then add 'CI Cleared'. label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optimumtact optimumtact optimumtact left review comments

@Cyberboss Cyberboss Cyberboss requested changes

@ZephyrTFA ZephyrTFA ZephyrTFA approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CI Cleared Applying this label allows a pull request from a fork to access repository secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlsnow301 @optimumtact @Cyberboss @ZephyrTFA