Skip to content

Load all schemas before testing them #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2016
Merged

Load all schemas before testing them #67

merged 1 commit into from
Nov 15, 2016

Conversation

bergie
Copy link
Contributor

@bergie bergie commented Nov 15, 2016

No description provided.

@bergie bergie merged commit b19ea37 into master Nov 15, 2016
@bergie bergie deleted the check_missing branch November 15, 2016 17:51
@jonnor
Copy link
Contributor

jonnor commented Nov 15, 2016 •
edited
Loading

@bergie what does this fix? Good to check against missing. But surely there was nothing missing, otherwise how did all the invalid tests pass???

@bergie
Copy link
Contributor Author

bergie commented Nov 15, 2016

@jonnor it was load order dependent. So when I added checks against missing, some tests started failing. Loading all schemas into tv4 before starting actual test run fixed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergie @jonnor