Document undocumented properties #69
Conversation
bergie
changed the title
|
@jonnor please review |
| @@ -31,4 +38,6 @@ properties: | |||
| - { type: 'null' } | |||
| - { type: 'string', format: 'date-time' } | |||
|
|
|||
| required: [content] | |||
| anyOf: | |||
There was a problem hiding this comment.
Shouldn't this be oneOf? Must either have content or starred, right?
There was a problem hiding this comment.
You're correct. Let me push a fix
| @@ -52,3 +52,6 @@ properties: | |||
| example: Bergie Today | |||
| required: [url] | |||
| required: [url] | |||
| dependencies: | |||
There was a problem hiding this comment.
Nice, did not know that feature before.
There was a problem hiding this comment.
There was a problem hiding this comment.
Me neither. But trying to get the validation to be as close as possible to reality made me peruse the JSON schema docs and find bunch of goodies.
Ideally we should get these to stage where schemas can be trusted for all other validation except side effects (UUID references matching database etc). But that will probably take a few iterations
| @@ -146,7 +148,7 @@ properties: | |||
| minimum: 0.0 | |||
| maximum: 1.0 | |||
| site_lang: | |||
| type: string | |||
| type: [string, "null"] | |||
There was a problem hiding this comment.
Bit annoying to allow null everywhere?
There was a problem hiding this comment.
@jonnor yeah, but otherwise validation fails for nullable properties.
|
Looking good. |
|
@bergie Merged, deploy at will |
Handles various low-hanging issues by adding missing properties where needed.