-
Notifications
You must be signed in to change notification settings - Fork 9
Fix full schemas #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix full schemas #77
Conversation
html: '<audio></audio>' | ||
- | ||
_valid: false | ||
_name: "valid-audio-without-type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove these testcases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems they were moved into contentblock.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from here to contentblock
since after dereferencing they need the full content block definition for validation to work correctly
src: | ||
"$ref": "contentblock.json#/definitions/src" | ||
description: Block type | ||
example: "text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example says "text", but only valid in the enum is article
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
src: | ||
"$ref": "contentblock.json#/definitions/src" | ||
description: Block type | ||
example: "text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, invalid example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@bergie this means that one should never use the individual block schemas right, as they are not complete? For instance |
Well, the JSON needs to be build so |
@jonnor good to go? |
@bergie deploy at will |
Currently our full schemas are broken due to circular references in
contentblock
. This makes JSON schema derefencing failures fatal, and fixes the contentblock->specific type circular refs