User can use schema #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergie
suggested changes
Jan 20, 2017
| @@ -17,4 +17,8 @@ properties: | |||
| avatar: | |||
| type: string | |||
| example: "http://example.net/user.png" | |||
| canUse: | |||
| description: Feature flagging based on user's plan. Available flags are siteMediaCta, edCta, edEmbed | |||
| type: object | |||
There was a problem hiding this comment.
Can you also document the properties of canUse here?
bergie
reviewed
Jan 20, 2017
| @@ -17,4 +17,8 @@ properties: | |||
| avatar: | |||
| type: string | |||
| example: "http://example.net/user.png" | |||
| required: [uuid, name] | |||
| canUse: | |||
| description: Feature flagging based on user's plan. Available flags are siteMediaCta, edCta, edEmbed | |||
There was a problem hiding this comment.
this is the wrong way to do it, actually add the properties to the object with types, descriptions etc.
bergie
reviewed
Jan 20, 2017
| @@ -17,4 +17,16 @@ properties: | |||
| avatar: | |||
| type: string | |||
| example: "http://example.net/user.png" | |||
| required: [uuid, name] | |||
| canUse: | |||
There was a problem hiding this comment.
These need to be under a properties key, like in
apidocs/schemata/siteconfig.yaml
Line 32 in f859abf
bergie
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/the-grid/apis/pull/742