-
Notifications
You must be signed in to change notification settings - Fork 773
add cygwin support #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cygwin support #1871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. For the ignored tests can you add a reason why they are ignored.
@Thomasdezeeuw I enabled the 4 ignored tests, adding some workarounds to complete the handshake:
|
CI is failing but it's not my problem. The master branch also fails. |
I proposed a fix for CI in #1883 . |
Thanks @Berrysoft |
This PR adds cygwin support. It uses the POSIX poll as backend. I tried my best to fix the tests. Some of them are ignored reasonably, while some of them are not - related to the
UnixListener
andUnixStream
. I don't understand them yet.