Skip to content

Review/refactor tesselator #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Review/refactor tesselator #1437

merged 2 commits into from
Jun 11, 2025

Conversation

tpaviot
Copy link
Owner

@tpaviot tpaviot commented Jun 11, 2025

Rafctor Tesselator to use more modern c++

Summary by Sourcery

Refactor the ShapeTesselator implementation to modernize its C++ usage and improve safety, maintainability, and performance.

Enhancements:

  • Replace raw arrays and manual memory management with std::vector and std::unique_ptr for faces, edges, and consolidated mesh data
  • Decompose tessellation logic into focused helper methods (e.g., ProcessFaces, ProcessNormals, ProcessTriangles, ComputeEdges)
  • Use STL algorithms (e.g., std::accumulate, std::move_iterator) and reserve/move semantics to optimize memory allocation and data consolidation
  • Introduce RAII and noexcept/const correctness across public interface and replace manual delete operations
  • Modernize export routines and stream formatting using std::ostringstream and range-based operations

Build:

  • Bump C++ standard requirement from C++11 to C++14 in CMakeLists.txt

@tpaviot tpaviot merged commit 6cd56a5 into master Jun 11, 2025
0 of 14 checks passed
@tpaviot tpaviot deleted the review/refactor-tesselator branch June 11, 2025 12:52
Copy link

sourcery-ai bot commented Jun 11, 2025

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant