test: L0_orca_trtllm fixed #8191
Conversation
…directory structure and add func defn
|
|
||
| cd ${BASE_DIR} | ||
| } | ||
|
|
||
| clone_tensorrt_llm_backend_repo | ||
| build_gpt2_base_model | ||
| build_gpt2_tensorrt_engine |
There was a problem hiding this comment.
How did this call to build_gpt2_tensorrt_engine previously work if the function didn't exist until this PR?
There was a problem hiding this comment.
I tried finding an answer to this, but was unable to
Checked with @mc-nv if anything changed in the way CI runs or mounts. No luck.
Double checked if the test did actually run as expected before it broke (It did)
Test started breaking when we merged 24.04 release branch into main.
They were originally ONLY defined in L0_perf_tensorrt_llm/test.sh and prev tests used to pick the defn from there
There was a problem hiding this comment.
They were originally ONLY defined in L0_perf_tensorrt_llm/test.sh and prev tests used to pick the defn from there
Do we do a source L0_perf_tensorrt_llm/test.sh somewhere when running this test? I didn't see it in this bash script. Maybe on gitlab job side?
There was a problem hiding this comment.
Maybe because there is no set +e so bash just ignore the error.
| @@ -138,6 +145,42 @@ function kill_server { | |||
| done | |||
| } | |||
|
|
|||
| function clone_tensorrt_llm_backend_repo { | |||
There was a problem hiding this comment.
In the previous PR, I suggested moving these functions to qa/common/util.sh but somehow they were deleted instead of moved.
#8009 (comment)
What does the PR do?
Fix L0_orca_trtllm which was broken due to new changes in the trtllm directory structure.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Where should the reviewer start?
test.sh
Test plan:
NA
27767229
Caveats:
NA
Background
Test broke due to