Skip to content

Prepare official support for multiple hyperscript implementations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Prepare official support for multiple hyperscript implementations #7

wants to merge 4 commits into from

Conversation

brechtcs
Copy link
Contributor

@brechtcs brechtcs commented Oct 4, 2018 •
edited
Loading

This documents both createFactory functions. But because they don't really make sense when only hyperscript is officially supported, I've decided to do two more things:

  • Restructure the tests so new h implementations can be added easily
  • Split the factory functions into a separate file so they can be required without the hyperscript dependency

Closes #6 if accepted.

@brechtcs
Copy link
Contributor Author

brechtcs commented Oct 5, 2018

Hm, I discovered some problems with the new test setup. Since my hastscript PR syntax-tree/hastscript#8 landed yesterday, I decided to give it a try with the tests here, but it seems like there's still quite a few hyperscript specific asserts in there.

I'll close this for now and open a slimmed down PR without the test changes later.

@brechtcs brechtcs closed this Oct 5, 2018
@brechtcs brechtcs mentioned this pull request Oct 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brechtcs