Skip to content

[INTS25] - Add "Times Applied" Column to Review Dashboard #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

eric-mxrtin
Copy link

Notion ticket link

Add Times Applied Column to Review Dashboard

Implementation description

  • Added column
  • Updated queries to query for the timesApplied field
  • Mapped the string responses to numbers to make them sortable

Steps to test

  1. Go to Review Dashboard
  2. Observe the times applied column and sort by it

What should reviewers focus on?

  • Times applied column

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Comment on lines 69 to 74
const mapToNumericalValue = {
"This is my first time!": 0,
Once: 1,
Twice: 2,
"3 or more": 3,
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmh we'll have to provide some documentation for this... i forget that there's a 3+ option.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to circle back on this, let's hold this off right now and ask the designers how they would want to display this (should be a short conversation LOL)

but in our DB, we will store it as 0, 1, 2, 3 and document that 3 means 3 or more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok design said that it should look like

const mapToNumericalValue = {
      "This is my first time!": "0",
      Once: "1",
      Twice: "2",
      "3 or more": "3+",
    };

@eric-mxrtin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants