Skip to content

Carolyn/remove package lock #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

carolynzhang18
Copy link

Notion ticket link

Remove package lock

Implementation description

  • Remove package-lock.json and add it to .gitignore

Steps to test

  1. 👍

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for uwblueprint failed.

Name Link
🔨 Latest commit 8267c0c
🔍 Latest deploy log https://app.netlify.com/projects/uwblueprint/deploys/683f9cbaaec8500008615d0a

@carolynzhang18 carolynzhang18 changed the base branch from main to staging June 4, 2025 01:14
Copy link

@eric-mxrtin eric-mxrtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mxc-maggiechen
Copy link

Oh I forgot to mention, there are some PR naming conventions that this repo follows to differentiate recruitment platform PRs and other BP website update PRs. See this Notion doc for more details: https://www.notion.so/uwblueprintexecs/PR-Commits-Grooming-Guidelines-a9e70702b8484557b568d811f0f4ef58?source=copy_link

Otherwise thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants