Skip to content

Move lapack_info_check inside of onemkl_cusolver_host_task #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Move lapack_info_check inside of onemkl_cusolver_host_task #238

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9208387
Move dev_info check to host_task
Aug 16, 2022
c515f25
Asynchronously free ipiv 32-bit memory
Aug 16, 2022
e12107b
User helper for depends on events
Aug 16, 2022
654e5f5
Remove unncessary reinterpret_cast for ipiv32
Aug 16, 2022
39d8f65
Wait on scratchpad_size host task
Aug 16, 2022
ac4f639
Pass queue by reference to cusolver host task
Aug 16, 2022
87b4900
Update for includes for removed CL namespace
Aug 16, 2022
1880bf9
Merge branch 'develop' into infocheck
Oct 11, 2022
0d057c3
Resolved conflict in cusolver_helper.hpp
Oct 11, 2022
cf2a7dd
Update cusolver_batch cases.
JackAKirk Oct 13, 2022
0d02373
Applied Aidan's suggestions.
JackAKirk Oct 13, 2022
91bbde4
Merge branch 'develop' into info_check_rebased
JackAKirk Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into info_check_rebased
  • Loading branch information
@JackAKirk
JackAKirk authored Oct 26, 2022
commit 91bbde4b7e662a6097b11d503f88d4b981d8619a
3 changes: 1 addition & 2 deletions src/lapack/backends/cusolver/cusolver_lapack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,6 @@ inline void potrf(const char *func_name, Func func, sycl::queue &queue, oneapi::
lda, scratch_, scratchpad_size, dev_info_d);

lapack_info_check_and_free(dev_info_d, __func__, func_name);

});
});
}
Expand Down Expand Up @@ -1436,7 +1435,7 @@ inline sycl::event getrs(const char *func_name, Func func, sycl::queue &queue,
auto b_ = reinterpret_cast<cuDataType *>(b);
cusolverStatus_t err;
CUSOLVER_ERROR_FUNC_T_SYNC(func_name, func, err, handle, get_cublas_operation(trans), n,
nrhs, a_, lda, ipiv32, b_, ldb, nullptr);
nrhs, a_, lda, ipiv32, b_, ldb, nullptr);
});
});

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.