[Docs] Introduce backend maintainer roles #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodburns
reviewed
May 14, 2025
|
|
||
| Requirements: | ||
| * Experience as Contributor in the specific backend for at least 6 months. | ||
| * Commit at least 25% of working time to the project. |
There was a problem hiding this comment.
Should we include this requirement, or just use the one below that says "Commits to being responsible for that specific backend" ?
Rbiessy
reviewed
May 14, 2025
There was a problem hiding this comment.
Is the plan to also update CODEOWNERS to automatically add backend maintainers to PRs review?
I think ideally we would want to ping both backend maintainers and domain owners? I think this could be done if we add patterns such as:
/src/blas/backends/cublas/ @uxlfoundation/onemath-gpu-nvidia @uxlfoundation/onemath-blas-write
and similar for other backends and domains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related RFC: #673
Updates the CONTRIBUTING.md and MAINTAINERS.md files to introduce the new backend maintainer roles as described in the corresponding RFC. If approved, these roles will need to be created separately from this pull request:
@uxlfoundation/onemath-cpu-aarch64
@uxlfoundation/onemath-cpu-x64
@uxlfoundation/onemath-gpu-amd
@uxlfoundation/onemath-gpu-intel
@uxlfoundation/onemath-gpu-nvidia