Skip to content

Make httpclient thread safe #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Make httpclient thread safe #136

wants to merge 1 commit into from

Conversation

alxtkr77
Copy link
Contributor

@alxtkr77 alxtkr77 closed this May 14, 2025
@alxtkr77 alxtkr77 reopened this May 14, 2025
@gtopper gtopper self-requested a review May 14, 2025 13:45
gtopper
gtopper reviewed May 18, 2025
View reviewed changes
Copy link
Member

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical that the issue is actually thread safety. I would try to add the error to self._send_request_exceptions so the request can be retried with a new connection.

@gtopper
Copy link
Member

gtopper commented May 18, 2025

Btw, from what I've read, I'd check the ingress controller (nginx) logs, since it could be closing the connection on the client, which would be consistent with finding nothing in the webapi logs.

@alxtkr77 alxtkr77 force-pushed the ML-9894 branch 2 times, most recently from 054e774 to 6caa3a9 Compare May 19, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtopper gtopper gtopper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxtkr77 @gtopper