Skip to content

Make get trusted types-compliant attribute value take strings instead… #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Make get trusted types-compliant attribute value take strings instead… #590

merged 1 commit into from
Jul 3, 2025

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Jul 3, 2025 •
edited by pr-preview bot
Loading

… of an Attr object

This will allow the DOM specification to be cleaner

Preview | Diff

@lukewarlow lukewarlow requested a review from fred-wang July 3, 2025 08:28
fred-wang
fred-wang approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This algo is not used in TT spec, so seems safe.

@lukewarlow
Make get trusted types-compliant attribute value take strings instead…
1887075 
… of an Attr object

This will allow the DOM specification to be cleaner
@lukewarlow lukewarlow force-pushed the switch-attribute-for-values branch from 0b2f32e to 1887075 Compare July 3, 2025 08:46
@lukewarlow lukewarlow merged commit f69c6ae into w3c:main Jul 3, 2025
3 checks passed
github-actions bot added a commit that referenced this pull request Jul 3, 2025
@lukewarlow @github-actions
Make get trusted types-compliant attribute value take strings instead…
c3e1d38 
… of an Attr object (#590)

SHA: f69c6ae
Reason: push, by lukewarlow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred-wang fred-wang fred-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewarlow @fred-wang