Skip to content

Pe 11 12 18 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2023
Merged

Pe 11 12 18 #5

merged 5 commits into from
Aug 29, 2023

Conversation

anandamarsh
Copy link

Worked on the following:

  • removed json renderer
  • made the height and fontsize adapt to the container
  • made the editor readonly (Mike to do the Go side of things)

@sawka
Copy link
Member

sawka commented Aug 28, 2023

PR looks good, didn't see any issues with the code.

This PR looks like a good place to also add the font family as well -- Set to "JetBrains Mono". Want to add that in before we merge?

@sawka sawka merged commit af25dc6 into main Aug 29, 2023
@anandamarsh anandamarsh deleted the PE_11_12_18 branch September 20, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandamarsh @sawka