Skip to content

Get custom tsconfig.json from the tsConfigFile option as the docs says #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danikaze
Copy link

@danikaze danikaze commented Jun 8, 2018

Documentation in README.md says that the custom tsconfig.json is read by the tsConfigFile option, but it doesn't work because the code is trying to get it from configFile field of the options.

Enabled the tsConfigFile without changing the current one to provide compatibility with previous versions, but follow the documentation.

The tsconfig.json file is needed for rules that need type check, so it's something necessary to have working.

@bhovhannes
Copy link
Collaborator

@danikaze , configFile option is used to specify tslint configuration and tsConfigFile is used to specify custom tsconfig.json - typescript configuration.
These 2 options server for different purpose and I think it will be wrong to mix them.

Do you have any issue you're trying to fix with you PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants