Skip to content

Global: deprecating demoted versions #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

Garneauma
Copy link
Collaborator

  • Deprecating demoted versions of GCWeb components
  • Removing elements that have been deprecated for more than 1 year

@Garneauma
Copy link
Collaborator Author

Pre-approved upon successful review.

@Garneauma Garneauma force-pushed the deprecate-demoted branch from 358adca to 68485ef Compare June 16, 2025 18:57
@Ricokola Ricokola added this to the v17.0.0 milestone Jul 3, 2025
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component impacted:

  • Major - Byline - Feature deprecated exception when context of use is a news article
  • Major - Contributor - Context of use changed to be limited inside the page details section, along with the date modified.
  • Major - GC Feedback - Deprecated of the initial ajax fragment version which didn't included the PII check.
  • Major - Site footer - Removed CSS that was used by deprecated pattern prior GCWeb v13.0.0
  • Major - Site footer - Deprecated version 8.1 and 8.0
  • Major - Page details - Deprecated version 3.0, 3.1 and 3.2
  • Major - Template, Institutional landing page - Removal of deprecated template v1
  • Major - Template, Topic - Deprecate version 2.0.0 (should use v2.2 instead)

Todo:

  • Add documentation for byline regarding its exception - A new variation should be added. But let's keep "Deprecated" to avoid miss use.

Check and adjust if needed:

  • Ensure the asset in the sub-folder "deprecated" are not part of our distribution. For example, this file should not be there: assets/deprecated/page-feedback-v1-en.html

Reviewed and tested locally

@duboisp
Copy link
Member

duboisp commented Jul 9, 2025

Confirmed: the Deprecated folder are not included in the distribution.

@duboisp
Copy link
Member

duboisp commented Jul 9, 2025

@BeraJosh this is ready for your security check, This is a clean up task where we remove code that has been deprecated for more than a year and we also identified code that is now officially deprecated. There should be no impact. No JS change, mostly documentation and CSS cleanup

@duboisp
Copy link
Member

duboisp commented Jul 9, 2025

Note: The byline was integrated as a contextualized configuration of the "Main page title" component. So no need to adjust the documentation.

@duboisp duboisp removed their assignment Jul 9, 2025
@Ricokola Ricokola modified the milestones: v17.0.0, v17.0.1 Jul 10, 2025
@duboisp duboisp modified the milestones: v17.0.1, v17.0.0 Jul 10, 2025
@duboisp
Copy link
Member

duboisp commented Jul 10, 2025

FYI - Security check was completed by @BeraJosh today without any concern

@duboisp duboisp merged commit 01f2c5f into wet-boew:master Jul 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants