Static header: adding a visible border to the search bar #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garneauma
requested changes
Jun 17, 2025
Garneauma
requested changes
Jun 18, 2025
sites/search/index.json-ld
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "@context": { | |||
| "@version": 1.1, | |||
| "@version": 1.2, | |||
There was a problem hiding this comment.
Do not change this, it's the version of the terms context. It's not related to the component itself. :)
sites/search/_base.scss
Outdated
| @@ -40,6 +40,11 @@ | |||
| box-shadow: none; | |||
| color: #555; | |||
| position: relative; | |||
|
|
|||
| :active { | |||
There was a problem hiding this comment.
Pretty sure this would not do anything. Have you tested it?
duboisp
requested changes
Jun 30, 2025
sites/search/_base.scss
Outdated
|
|
||
| &:focus, | ||
| &:active { | ||
| border-color: #66afe9; |
There was a problem hiding this comment.
We should use the "outline" style instead of the border. The outline wont interfere with the placement of the input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static header: adding a visible border to the search bar
Related to WET-264