Skip to content

Adding failing tests that need to resolve #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from
Draft

Adding failing tests that need to resolve #67

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
83c3ddd
The `ui` option is now required for the SessionKit
aaroncox May 29, 2023
44c784c
Split SessionKit initialization to both "args" and "options"
aaroncox May 29, 2023
03ff1fd
Move `onSignComplete` to after all signing ops finish
aaroncox Jun 9, 2023
cfbcda2
Allow restoring without serialized session
aaroncox Jun 9, 2023
ef7a000
Track and allow restoring a default account per-chain
aaroncox Jun 29, 2023
7bb6984
Reapplied 4faab919a3154dc875279e54c3baf9448de7eefa
aaroncox Jun 29, 2023
3dfec19
Version 1.0.0-beta1
aaroncox Jun 30, 2023
09e7d4c
Moved all mock data to its own repository
aaroncox Jun 30, 2023
bdb09d4
Updating @wharfkit/mock-data and MOCK_DIR
aaroncox Jun 30, 2023
6a7a24d
Fixing ci-test
aaroncox Jun 30, 2023
d271f9f
Updating @wharfkit/mock-data
aaroncox Jun 30, 2023
c254b65
Allow manually passing in ABIDef for use in Sessions
aaroncox Jul 3, 2023
d26324c
Version 1.0.0-beta2
aaroncox Jul 3, 2023
e581be6
Version 1.0.0-beta3
aaroncox Jul 5, 2023
63d670c
Renamed AbiProvider to ABICache since it's an extension of ESR
aaroncox Jul 5, 2023
f8ec7d0
Better defined ABICacheInterface
aaroncox Jul 5, 2023
f4ada69
Version 1.0.0-beta4
aaroncox Jul 6, 2023
d1946fe
Prevent uneeded get_info calls when resolving
aaroncox Jul 26, 2023
a0a087f
Linting of tests
aaroncox Jul 26, 2023
39946aa
Adding tests for placeholder resolution
aaroncox Jul 26, 2023
cc1f063
Adding test data for placeholder resolution
aaroncox Jul 26, 2023
0c33616
Unused test cleanup
aaroncox Jul 26, 2023
891b6b1
Linting
aaroncox Jul 26, 2023
c53fc44
Adding failing tests that need to resolve
aaroncox Jul 26, 2023
8ee946b
Removing unused import
aaroncox Jul 26, 2023
ab5d284
Merge branch 'dev' into placeholder-resolution
aaroncox Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reapplied 4faab91
  • Loading branch information
@aaroncox
aaroncox committed Jun 29, 2023
commit 7bb6984cff5e9435561e72d1cb0adb666422143c
9 changes: 5 additions & 4 deletions src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,10 +430,6 @@ export class Session {
context
)

if (context.ui) {
await context.ui.onSignComplete()
}

// Merge signatures in to the TransactResult
result.signatures.push(...walletResponse.signatures)

Expand All @@ -457,6 +453,11 @@ export class Session {
// Run the `afterSign` hooks that were registered by the TransactPlugins
for (const hook of context.hooks.afterSign) await hook(result, context)

// Notify the UI that the signing operations are complete
if (context.ui) {
await context.ui.onSignComplete()
}

if (willBroadcast) {
if (context.ui) {
// Notify the UI that broadcast logic will be run against the transaction
Expand Down