Skip to content

update go version to 1.24.0 #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BaptisteMoureaux
Copy link

@BaptisteMoureaux BaptisteMoureaux commented Apr 2, 2025

Update the go version to 1.24.0,

it's the first time i'm contributing to something, correct me if I did something wrong here 😅


Important

Update Go version to 1.24.0 in Dockerfile and lsp/Dockerfile.

  • Dockerfile:
    • Update GO_VERSION from 1.22.5 to 1.24.0.
  • lsp/Dockerfile:
    • Update Go tarball names to go1.24.0.linux-amd64.tar.gz, go1.24.0.linux-arm64.tar.gz, and go1.24.0.linux-armv6l.tar.gz for respective architectures.

This description was created by Ellipsis for 8c63606. It will automatically update as commits are pushed.

Copy link
Contributor

github-actions bot commented Apr 2, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8c63606 in 46 seconds

More details
  • Looked at 34 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. Dockerfile:92
  • Draft comment:
    Updated GO_VERSION is correctly set to 1.24.0. Ensure dependent tooling is compatible.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. lsp/Dockerfile:24
  • Draft comment:
    Use of 'go1.24.0' tarball for amd64 updated correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. Dockerfile:92
  • Draft comment:
    Updated GO_VERSION to 1.24.0; ensure dependencies remain compatible.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. lsp/Dockerfile:24
  • Draft comment:
    Bump Go archive references to 1.24.0 consistently for amd64, arm64, and armhf.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
5. Dockerfile:135
  • Draft comment:
    Typo detected: The error message on line 135 uses 'pwshell' instead of 'powershell'. Please correct the typo.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. Dockerfile:186
  • Draft comment:
    Minor typographical suggestion: In the comment on line 186, consider changing 'it is ran' to 'it is run' for proper grammar.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_iaWRW2UzB1iehMVK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@BaptisteMoureaux
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 2, 2025
@rubenfiszel
Copy link
Contributor

Hi, you did well but we need to investigate what impact it would have on existing scripts that were deployed with a prior version

@BaptisteMoureaux
Copy link
Author

Hi, you did well but we need to investigate what impact it would have on existing scripts that were deployed with a prior version

I understand, do you think it would be possible to atleast push the LSP part only ? I'm using 1.24 external packages and the lsp fails to import them so it's a bit annoying to use them blindly right now.

Otherwise I'll just wait, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants