Skip to content

chore(main): release 1.493.2 #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented May 28, 2025

🤖 I have created a release beep boop

1.493.2 (2025-05-28)

Bug Fixes

  • improve monaco editor memory leak (e0f4f83)
  • improve monaco javascript extra lib refresh (7b70348)

This PR was generated with Release Please. See documentation.


Important

Release 1.493.2 with bug fixes for Monaco editor memory leak and JavaScript library refresh.

  • Release:
    • Update version.txt to 1.493.2.
    • Update CHANGELOG.md with bug fixes for version 1.493.2.
  • Bug Fixes:
    • Fix Monaco editor memory leak.
    • Improve Monaco JavaScript extra library refresh.

This description was created by Ellipsis for 45f3f18. You can customize this summary. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d47b50
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 5d48ceb in 4 minutes and 11 seconds. Click for details.
  • Reviewed 24 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
  • Draft comment:
    Version bumped to 1.493.2; ensure this update is coordinated with all release artifacts.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. CHANGELOG.md:8
  • Draft comment:
    Typographical suggestion: In the bullet point on line 8, consider capitalizing “JavaScript” (e.g., “Improve Monaco JavaScript extra lib refresh”) for consistency and clarity.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment is about a stylistic change (capitalization) in a changelog, not a code change. The rules explicitly state not to make comments unless a code change is required, and not to make unimportant or purely informative comments. This is a minor typographical suggestion and does not impact the logic or functionality of the codebase. Perhaps consistent capitalization in changelogs could be important for some teams, but the rules are clear that such comments are not actionable code changes. Even if consistency is desirable, the rules prioritize actionable code changes over stylistic or typographical suggestions in documentation like changelogs. This comment should be deleted as it is purely a typographical suggestion and does not require a code change, violating the review rules.

Workflow ID: wflow_iUU72JNV6yZsyEd6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from a66ad3c to 45f3f18 Compare May 28, 2025 13:48
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 45f3f18 in 26 seconds. Click for details.
  • Reviewed 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
  • Draft comment:
    Version bump to 1.493.2 is correctly updated.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_gEqphBYBguIP7BIL

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@rubenfiszel rubenfiszel merged commit 6ffb40b into main May 28, 2025
1 check was pending
@rubenfiszel rubenfiszel deleted the release-please--branches--main--components--windmill branch May 28, 2025 13:51
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
@rubenfiszel
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant