-
Notifications
You must be signed in to change notification settings - Fork 689
internal: Small claude improvements #5832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying windmill with
|
Latest commit: |
b785a9e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://dc128540.windmill.pages.dev |
Branch Preview URL: | https://claude2.windmill.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to b785a9e in 1 minute and 46 seconds. Click for details.
- Reviewed
507
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
10
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .cursor/rules/rust-best-practices.mdc:50
- Draft comment:
Nice addition reminding developers to update the openapi spec. Consider rewording to "Don't forget to update the backend/windmill-api/openapi.yaml after modifying an API endpoint." - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. .github/workflows/aider-after-review.yaml:93
- Draft comment:
Updated rules_files paths to reference centralized docs. Verify that the space‐separated list is parsed correctly by your tooling. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. .github/workflows/aider-external.yaml:76
- Draft comment:
Consistently updated rules_files paths to use the .cursor/rules documents. Confirm that the new file paths are correct. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. .github/workflows/aider.yaml:161
- Draft comment:
Updated rules_files to reference the centralized documentation (.cursor/rules). This improves maintainability—ensure the new paths are supported by your processing tools. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
5. .github/workflows/claude.yml:69
- Draft comment:
Added non-interactive '-y' flag to the Rust installation command and updated custom instructions to create a draft PR. This change enhances automation by avoiding manual input. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
6. CLAUDE.md:1
- Draft comment:
CLAUDE.md has been streamlined to reference the centralized documentation. This reduces duplication—ensure the referenced files exist and are up-to-date. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
7. backend/CLAUDE.md:1
- Draft comment:
Removed the redundant backend CLAUDE documentation. Verify that all internal references now point to the centralized docs. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
8. frontend/CLAUDE.md:1
- Draft comment:
Removed the redundant frontend CLAUDE documentation in favor of centralized documentation. Ensure that developers are aware of the new documentation locations. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
9. .cursor/rules/rust-best-practices.mdc:50
- Draft comment:
Typo note: Consider capitalizing "api endpoint" to "API endpoint" for consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =20%
<= threshold50%
The comment suggests a minor stylistic change, which is not strictly necessary for functionality or correctness. It doesn't address a potential bug or improvement in logic, nor does it suggest a test or refactoring. It seems to be more of a nitpick rather than a substantial comment.
10. .github/workflows/aider-after-review.yaml:93
- Draft comment:
The file names in the rules_files all use the extension.mdc
, which is unusual for markdown files (typically.md
). Please verify if this is intentional or a typographical error. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It's asking for verification ("Please verify if..."), it's speculative (assumes .mdc is a typo without evidence), and most importantly, we have no context about whether .mdc is actually incorrect. The files could be using .mdc extension for a specific reason in this project. Without strong evidence that .mdc is wrong, we should not keep this comment. The files might actually be incorrectly named and .mdc could be a real typo that should be fixed. The comment could be preventing a real issue. Without clear evidence that .mdc is incorrect, and given that this is a deliberate change from the previous version, we should assume the authors know what extension they want to use. The comment is just speculative. Delete this comment as it's speculative, asks for verification, and we don't have strong evidence that .mdc is incorrect.
Workflow ID: wflow_RzW3zNWmQ8a0SA4j
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update workflow files and documentation to use new best practice guides and modify PR instructions for draft creation.
aider-after-review.yaml
,aider-external.yaml
,aider.yaml
, andclaude.yml
to use.cursor/rules/rust-best-practices.mdc
,.cursor/rules/svelte5-best-practices.mdc
, and.cursor/rules/windmill-overview.mdc
for rules files.allowed_tools
inclaude.yml
to includeBash(curl https://sh.rustup.rs -sSf | sh -s -- -y)
.custom_instructions
inclaude.yml
to create draft PRs instead of regular PRs.CLAUDE.md
with references to.cursor/rules
files for app overview and modification rules.backend/CLAUDE.md
andfrontend/CLAUDE.md
as they are now redundant.This description was created by
for b785a9e. You can customize this summary. It will automatically update as commits are pushed.